Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSM] Fix syscall dirty flag after execve #27679

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Conversation

Gui774ume
Copy link
Contributor

What does this PR do?

This PR fixes the syscall "dirty" flag after an execve and adds functional tests to make sure we don't forget why it's there.

Motivation

Before this fix, some syscall drift events could have an empty list of syscalls.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@Gui774ume Gui774ume added this to the 7.57.0 milestone Jul 17, 2024
@Gui774ume Gui774ume requested a review from a team as a code owner July 17, 2024 17:15
@Gui774ume Gui774ume added the qa/done QA done before merge and regressions are covered by tests label Jul 17, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 17, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=39764006 --os-family=ubuntu

Note: This applies to commit 27ef1a8

Copy link
Contributor

@spikat spikat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nit comments, otherwise LGTM :)

pkg/security/tests/security_profile_test.go Outdated Show resolved Hide resolved
pkg/security/tests/security_profile_test.go Show resolved Hide resolved
pkg/security/tests/security_profile_test.go Outdated Show resolved Hide resolved
@Gui774ume Gui774ume force-pushed the will/fix-syscall-dirty branch from 65a58a5 to d29350b Compare July 18, 2024 10:57
@pr-commenter
Copy link

pr-commenter bot commented Jul 18, 2024

Regression Detector

Regression Detector Results

Run ID: c27f2832-7c06-4964-bf3d-2a0b9d4af9c4 Metrics dashboard Target profiles

Baseline: 9bc7fa6
Comparison: 1a74a88

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
tcp_syslog_to_blackhole ingress throughput +2.07 [-10.85, +15.00] Logs
basic_py_check % cpu utilization +0.53 [-2.11, +3.17] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] Logs
idle memory utilization -0.53 [-0.58, -0.49] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.55 [-1.44, +0.34] Logs
otel_to_otel_logs ingress throughput -0.91 [-1.72, -0.11] Logs
pycheck_1000_100byte_tags % cpu utilization -1.10 [-5.93, +3.74] Logs
file_tree memory utilization -1.79 [-1.88, -1.70] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Contributor

@spikat spikat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gui774ume Gui774ume force-pushed the will/fix-syscall-dirty branch 3 times, most recently from 76ce866 to b9523ae Compare July 18, 2024 18:48
@Gui774ume
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 22, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

@Gui774ume
Copy link
Contributor Author

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Jul 22, 2024

⚠️ MergeQueue: This merge request build was cancelled

This merge request build was cancelled

If you need support, contact us on Slack #devflow!

@Gui774ume Gui774ume force-pushed the will/fix-syscall-dirty branch from b9523ae to 1a74a88 Compare July 22, 2024 09:43
@Gui774ume Gui774ume force-pushed the will/fix-syscall-dirty branch from 579c561 to 27ef1a8 Compare July 22, 2024 12:23
@Gui774ume
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 22, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 76d9ce0 into main Jul 22, 2024
231 checks passed
@dd-mergequeue dd-mergequeue bot deleted the will/fix-syscall-dirty branch July 22, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants