-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSM] Fix syscall dirty flag after execve #27679
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=39764006 --os-family=ubuntu Note: This applies to commit 27ef1a8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nit comments, otherwise LGTM :)
65a58a5
to
d29350b
Compare
Regression DetectorRegression Detector ResultsRun ID: c27f2832-7c06-4964-bf3d-2a0b9d4af9c4 Metrics dashboard Target profiles Baseline: 9bc7fa6 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +2.07 | [-10.85, +15.00] | Logs |
➖ | basic_py_check | % cpu utilization | +0.53 | [-2.11, +3.17] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
➖ | idle | memory utilization | -0.53 | [-0.58, -0.49] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.55 | [-1.44, +0.34] | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.91 | [-1.72, -0.11] | Logs |
➖ | pycheck_1000_100byte_tags | % cpu utilization | -1.10 | [-5.93, +3.74] | Logs |
➖ | file_tree | memory utilization | -1.79 | [-1.88, -1.70] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
76ce866
to
b9523ae
Compare
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
/merge -c |
This merge request build was cancelled If you need support, contact us on Slack #devflow! |
…ormat check for security profiles
b9523ae
to
1a74a88
Compare
579c561
to
27ef1a8
Compare
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
This PR fixes the syscall "dirty" flag after an execve and adds functional tests to make sure we don't forget why it's there.
Motivation
Before this fix, some syscall drift events could have an empty list of syscalls.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes