Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix centos7 failures #27336

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fix centos7 failures #27336

merged 1 commit into from
Jul 4, 2024

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Jul 4, 2024

What does this PR do?

Partial backport of #27197 without bump of test-infra-definition

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jul 4, 2024
@chouetz chouetz requested a review from a team as a code owner July 4, 2024 14:43
@chouetz chouetz force-pushed the nschweitzer/centos branch from 7f51fcf to ac5e7ac Compare July 4, 2024 14:43
@chouetz chouetz requested a review from a team as a code owner July 4, 2024 14:43
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.80%. Comparing base (51a7526) to head (ac5e7ac).

Additional details and impacted files
@@            Coverage Diff             @@
##           7.55.x   #27336      +/-   ##
==========================================
+ Coverage   44.93%   45.80%   +0.86%     
==========================================
  Files        2354     2201     -153     
  Lines      272912   260618   -12294     
==========================================
- Hits       122641   119376    -3265     
+ Misses     140590   131808    -8782     
+ Partials     9681     9434     -247     
Flag Coverage Δ
amzn_aarch64 45.78% <ø> (+<0.01%) ⬆️
centos_x86_64 45.68% <ø> (+<0.01%) ⬆️
ubuntu_aarch64 45.77% <ø> (-0.01%) ⬇️
ubuntu_x86_64 45.77% <ø> (-0.01%) ⬇️
windows_amd64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jul 4, 2024

Regression Detector

Regression Detector Results

Run ID: f9b983bf-54d7-4847-920d-8ef0cbe9050d

Baseline: 51a7526
Comparison: ac5e7ac

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
basic_py_check % cpu utilization +0.61 [-2.16, +3.39]
uds_dogstatsd_to_api_cpu % cpu utilization +0.22 [-2.69, +3.13]
pycheck_1000_100byte_tags % cpu utilization +0.15 [-4.70, +5.00]
idle memory utilization +0.06 [+0.01, +0.11]
otel_to_otel_logs ingress throughput +0.01 [-0.35, +0.37]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput -0.01 [-0.02, -0.00]
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.07, +0.03]
file_tree memory utilization -0.53 [-0.66, -0.41]
tcp_syslog_to_blackhole ingress throughput -4.83 [-25.63, +15.97]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@chouetz
Copy link
Member Author

chouetz commented Jul 4, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 4, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in 7.55.x is 40m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 6fa3e57 into 7.55.x Jul 4, 2024
196 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nschweitzer/centos branch July 4, 2024 21:02
@github-actions github-actions bot added this to the 7.55.0 milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant