Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FA] Use the api to parse versions #27107

Merged
merged 9 commits into from
Jul 3, 2024
Merged

[FA] Use the api to parse versions #27107

merged 9 commits into from
Jul 3, 2024

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Jun 27, 2024

What does this PR do?

Use the installer API and the agent API to parse the versions and the states
Re-enable the scenario tests

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@coignetp coignetp added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/fleet-automation labels Jun 27, 2024
@coignetp coignetp added this to the 7.56.0 milestone Jun 27, 2024
@coignetp coignetp requested a review from a team as a code owner June 27, 2024 10:00
@coignetp coignetp marked this pull request as draft June 27, 2024 10:00
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jun 27, 2024

[Fast Unit Tests Report]

On pipeline 38230954 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Jun 27, 2024

Regression Detector

Regression Detector Results

Run ID: 98422404-edc7-439c-b571-93c97af1a348 Metrics dashboard Target profiles

Baseline: 4710289
Comparison: d322ba7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
basic_py_check % cpu utilization +1.12 [-1.46, +3.71] Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.65 [-0.24, +1.55] Logs
pycheck_1000_100byte_tags % cpu utilization +0.58 [-4.25, +5.40] Logs
otel_to_otel_logs ingress throughput +0.49 [-0.32, +1.30] Logs
idle memory utilization +0.10 [+0.07, +0.14] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] Logs
file_tree memory utilization -1.00 [-1.08, -0.91] Logs
tcp_syslog_to_blackhole ingress throughput -7.11 [-19.72, +5.51] Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@coignetp coignetp force-pushed the paul/fa-api-parse branch from 6395478 to a97f9e1 Compare June 28, 2024 13:05
@coignetp coignetp marked this pull request as ready for review June 28, 2024 14:00
@pr-commenter
Copy link

pr-commenter bot commented Jun 28, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38230954 --os-family=ubuntu

Note: This applies to commit d322ba7

@coignetp
Copy link
Contributor Author

coignetp commented Jul 3, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jul 3, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 83f4f18 into main Jul 3, 2024
205 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paul/fa-api-parse branch July 3, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants