[Windows] Adding property in installer to support driver rollback

[mrafi97]

What does this PR do?

Adds the properties DDDRIVERROLLBACK_NPM and DDDRIVERROLLBACK_PROCMON to allow for rollback of ddnpm and ddprocmon drivers after a failed install/upgrade.

To account for prior agent versions not having the uninstall rollback action, the installer will view previous and current versions and only perform rollbacks for newer agent versions.

Motivation

https://datadoghq.atlassian.net/browse/WINA-726

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

1. Run the Datadog Agent MSI with the property WIXFAILWHENDEFERRED=1 to induce an failed install/upgrade:

Start-Process -Wait msiexec -ArgumentList '/qn /i datadog-agent*.msi APIKEY="APIKEY" WIXFAILWHENDEFERRED=1'

2. Check running services:

Get-Service "datadog*" 
Get-Service "ddnpm" 
Get-Service "ddprocmon"

Expected results for failed install/upgrade:

• Fresh install: All services are removed
• Upgrade from 7.52, 7.54, 7.55: All services are still installed
• Upgrade from < 7.52: Only ddprocmon is removed

[alai97]

Looks good, one suggestion.

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 0fdd6713-40be-4652-8495-d1516ceac681 Metrics dashboard Target profiles

Baseline: 51437cf
Comparison: 09292f6

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	tcp_syslog_to_blackhole	ingress throughput	+3.00	[-9.81, +15.80]	Logs
➖	basic_py_check	% cpu utilization	+0.39	[-2.18, +2.96]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	+0.19	[-4.52, +4.91]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]	Logs
➖	idle	memory utilization	-0.01	[-0.05, +0.04]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.08	[-0.97, +0.81]	Logs
➖	otel_to_otel_logs	ingress throughput	-0.29	[-1.11, +0.52]	Logs
➖	file_tree	memory utilization	-1.81	[-1.90, -1.73]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=38259364 --os-family=ubuntu

Note: This applies to commit 09292f6

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 38259364 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[clarkb7]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!