Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in KMT initialization #26402

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

usamasaqib
Copy link
Contributor

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@usamasaqib usamasaqib added changelog/no-changelog team/ebpf-platform qa/done QA done before merge and regressions are covered by tests labels Jun 6, 2024
@usamasaqib usamasaqib added this to the 7.56.0 milestone Jun 6, 2024
@usamasaqib usamasaqib requested a review from a team as a code owner June 6, 2024 09:13
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 36030419 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented Jun 6, 2024

Regression Detector

Regression Detector Results

Run ID: 9c563cc2-62b8-4a14-8949-aa8695a8031d
Baseline: 30ff86b
Comparison: 703d522

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
idle memory utilization +0.16 [+0.12, +0.20]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
trace_agent_json ingress throughput -0.00 [-0.01, +0.01]
tcp_dd_logs_filter_exclude ingress throughput -0.04 [-0.07, -0.01]
otel_to_otel_logs ingress throughput -0.33 [-0.71, +0.06]
uds_dogstatsd_to_api_cpu % cpu utilization -0.39 [-3.38, +2.60]
basic_py_check % cpu utilization -0.56 [-3.47, +2.36]
pycheck_1000_100byte_tags % cpu utilization -0.66 [-5.45, +4.13]
file_tree memory utilization -1.33 [-1.42, -1.24]
tcp_syslog_to_blackhole ingress throughput -4.13 [-25.28, +17.02]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@usamasaqib
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 12, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 34m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit eac1af8 into main Jun 12, 2024
317 checks passed
@dd-mergequeue dd-mergequeue bot deleted the usama.saqib/fix-kmt-init branch June 12, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants