-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(opentelemetry): add OTEL_RESOURCE_ATTRIBUTES spaces trimming #26233
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=35701558 --os-family=ubuntu |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26233 +/- ##
===========================================
+ Coverage 45.10% 48.10% +2.99%
===========================================
Files 2353 538 -1815
Lines 271817 48912 -222905
===========================================
- Hits 122604 23528 -99076
+ Misses 139544 23945 -115599
+ Partials 9669 1439 -8230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Regression DetectorRegression Detector ResultsRun ID: d3a92b58-642a-46e4-a145-c6618d619e43 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | pycheck_1000_100byte_tags | % cpu utilization | +3.78 | [-1.19, +8.74] |
➖ | file_tree | memory utilization | +0.59 | [+0.46, +0.73] |
➖ | idle | memory utilization | +0.21 | [+0.17, +0.24] |
➖ | otel_to_otel_logs | ingress throughput | +0.11 | [-0.26, +0.48] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.03, +0.06] |
➖ | trace_agent_json | ingress throughput | +0.00 | [-0.01, +0.01] |
➖ | trace_agent_msgpack | ingress throughput | -0.00 | [-0.00, +0.00] |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.21, +0.20] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.42 | [-3.48, +2.64] |
➖ | basic_py_check | % cpu utilization | -1.26 | [-4.27, +1.74] |
➖ | tcp_syslog_to_blackhole | ingress throughput | -8.68 | [-28.88, +11.51] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
725d913
to
1293c9f
Compare
Signed-off-by: Wassim DHIF <[email protected]>
1293c9f
to
d2d78c6
Compare
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
❌ MergeQueue: The build pipeline contains failing jobs for this merge request Build pipeline has failing jobs for 9947a40 Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. You should have a look at the pipeline, wait for the build to finish and investigate the failures.
|
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Add spaces trimming for
OTEL_RESOURCE_ATTRIBUTES
.Motivation
This is needed for customer who have spaces in their
OTEL_RESOURCE_ATTRIBUTES
.Describe how to test/QA your changes
QA will be done with this PR: #26118