Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry): add OTEL_RESOURCE_ATTRIBUTES spaces trimming #26233

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

wdhif
Copy link
Member

@wdhif wdhif commented Jun 3, 2024

What does this PR do?

Add spaces trimming for OTEL_RESOURCE_ATTRIBUTES.

Motivation

This is needed for customer who have spaces in their OTEL_RESOURCE_ATTRIBUTES.

Describe how to test/QA your changes

QA will be done with this PR: #26118

@github-actions github-actions bot added the team/container-platform The Container Platform Team label Jun 3, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=35701558 --os-family=ubuntu

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.10%. Comparing base (d3371d7) to head (d2d78c6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #26233       +/-   ##
===========================================
+ Coverage   45.10%   48.10%    +2.99%     
===========================================
  Files        2353      538     -1815     
  Lines      271817    48912   -222905     
===========================================
- Hits       122604    23528    -99076     
+ Misses     139544    23945   -115599     
+ Partials     9669     1439     -8230     
Flag Coverage Δ
amzn_aarch64 49.10% <100.00%> (+3.14%) ⬆️
centos_x86_64 48.68% <100.00%> (+2.81%) ⬆️
ubuntu_aarch64 49.11% <100.00%> (+3.15%) ⬆️
ubuntu_x86_64 49.09% <100.00%> (+3.14%) ⬆️
windows_amd64 46.14% <100.00%> (-4.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2024

Regression Detector

Regression Detector Results

Run ID: d3a92b58-642a-46e4-a145-c6618d619e43
Baseline: d3371d7
Comparison: d2d78c6

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +3.78 [-1.19, +8.74]
file_tree memory utilization +0.59 [+0.46, +0.73]
idle memory utilization +0.21 [+0.17, +0.24]
otel_to_otel_logs ingress throughput +0.11 [-0.26, +0.48]
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.03, +0.06]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.01 [-0.21, +0.20]
uds_dogstatsd_to_api_cpu % cpu utilization -0.42 [-3.48, +2.64]
basic_py_check % cpu utilization -1.26 [-4.27, +1.74]
tcp_syslog_to_blackhole ingress throughput -8.68 [-28.88, +11.51]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@wdhif wdhif marked this pull request as ready for review June 3, 2024 13:59
@wdhif wdhif requested a review from a team as a code owner June 3, 2024 13:59
@clamoriniere clamoriniere added this to the 7.55.0 milestone Jun 3, 2024
@wdhif wdhif force-pushed the CONTP-218/wassim.dhif/otel-ust-trim branch from 725d913 to 1293c9f Compare June 3, 2024 14:24
@wdhif wdhif force-pushed the CONTP-218/wassim.dhif/otel-ust-trim branch from 1293c9f to d2d78c6 Compare June 3, 2024 14:33
@wdhif
Copy link
Member Author

wdhif commented Jun 4, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 4, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 28m.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Jun 4, 2024

MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 9947a40

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected before the end of the pipeline.

You should have a look at the pipeline, wait for the build to finish and investigate the failures.
When you are ready, re-add your pull request to the queue!

⚠️ Do NOT retry failed jobs directly.

They were executed on a temporary branch created by the merge queue. If you retry them, they are going to fail because the branch no longer exists.

Details

List of failed jobs:

Go to failed Gitlab pipeline.

If you need support, contact us on Slack #devflow with those details!

@wdhif
Copy link
Member Author

wdhif commented Jun 4, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 4, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 28m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 4335d82 into main Jun 4, 2024
226 checks passed
@dd-mergequeue dd-mergequeue bot deleted the CONTP-218/wassim.dhif/otel-ust-trim branch June 4, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants