-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issues): Enable a new issue workflow for automatic issue triage #26207
Conversation
[Fast Unit Tests Report] On pipeline 50274088 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 407d3f8 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +3.69 | [-0.20, +7.58] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.08 | [+1.34, +2.83] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +1.62 | [+0.87, +2.37] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.31 | [+0.25, +0.37] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.10 | [-0.68, +0.87] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.02 | [-0.76, +0.80] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.11, +0.12] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.70, +0.71] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.02 | [-0.65, +0.61] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.08 | [-0.86, +0.70] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.13 | [-0.61, +0.34] | 1 | Logs |
➖ | file_tree | memory utilization | -0.34 | [-0.48, -0.21] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.87 | [-1.02, -0.72] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle | memory utilization | -0.93 | [-1.00, -0.86] | 1 | Logs bounds checks dashboard |
➖ | pycheck_lots_of_tags | % cpu utilization | -2.05 | [-5.50, +1.40] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | -2.44 | [-5.34, +0.46] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
d5fe70f
to
4b4d2da
Compare
4b4d2da
to
352de06
Compare
runs-on: ubuntu-latest | ||
container: ghcr.io/datadog/agent-issue-auto-assign:latest | ||
permissions: | ||
issues: write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To update the label
.github/workflows/assign_issue.yml
Outdated
jobs: | ||
auto_assign_issue: | ||
runs-on: ubuntu-latest | ||
container: ghcr.io/datadog/agent-issue-auto-assign:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adaaf60
to
9e00624
Compare
053a14d
to
02b63e4
Compare
02b63e4
to
22e2875
Compare
/merge |
Devflow running:
|
What does this PR do?
Create a new Github workflow for
datadog-agent
issues, which assign automatically to a team.datadog-agent
repo, which is tedious with rate limitation.#agent-ask-anything
when no match is found.Motivation
Improve our reactivity on issues opened in the repository, especially as we are a public repo. Besides, we have sometimes issues opened here faster than our support channel
Additional Notes
The model generation code is also shipped with this PR
Possible Drawbacks / Trade-offs
The model was generated using past data (issues and PR) and used mappings between old and new teams. We might need to re-generate it from time to time to have it accurate.
Describe how to test/QA your changes
Successful test here