Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix on github wofklows #26206

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Minor fix on github wofklows #26206

merged 1 commit into from
Jun 4, 2024

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented May 31, 2024

What does this PR do?

Set correct requirement file name and set actions pinned with commit id

Motivation

Housekeeping

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@chouetz chouetz requested a review from a team as a code owner May 31, 2024 21:26
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels May 31, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 35625012 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented May 31, 2024

Regression Detector

Regression Detector Results

Run ID: b6f148bc-d643-4b56-b28f-1c070cef6dd0
Baseline: 1b73957
Comparison: 7927042

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
uds_dogstatsd_to_api_cpu % cpu utilization +3.51 [+0.47, +6.54]
pycheck_1000_100byte_tags % cpu utilization +0.20 [-4.65, +5.06]
basic_py_check % cpu utilization +0.12 [-2.87, +3.12]
idle memory utilization +0.06 [+0.01, +0.11]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
trace_agent_json ingress throughput -0.01 [-0.03, +0.01]
tcp_dd_logs_filter_exclude ingress throughput -0.02 [-0.07, +0.02]
otel_to_otel_logs ingress throughput -0.06 [-0.44, +0.32]
file_tree memory utilization -0.99 [-1.12, -0.85]
tcp_syslog_to_blackhole ingress throughput -10.92 [-31.10, +9.25]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Copy link
Contributor

@CelianR CelianR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@chouetz
Copy link
Member Author

chouetz commented Jun 4, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 4, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 28m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 525470f into main Jun 4, 2024
214 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nschweitzer/github branch June 4, 2024 10:53
@github-actions github-actions bot added this to the 7.55.0 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants