Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSM] Enable dump auto suppression by default #26197

Merged
merged 1 commit into from
May 31, 2024

Conversation

Gui774ume
Copy link
Contributor

What does this PR do?

This PR enables the dump auto suppression feature by default.

Motivation

This feature is ready to be enabled by default.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@Gui774ume
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 31, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@pr-commenter
Copy link

pr-commenter bot commented May 31, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=35592054 --os-family=ubuntu

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.98%. Comparing base (d407c3d) to head (c93e538).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #26197       +/-   ##
===========================================
+ Coverage   45.17%   51.98%    +6.80%     
===========================================
  Files        2349     1863      -486     
  Lines      270700   159784   -110916     
===========================================
- Hits       122296    83057    -39239     
+ Misses     138747    71944    -66803     
+ Partials     9657     4783     -4874     
Flag Coverage Δ
amzn_aarch64 52.19% <100.00%> (+6.18%) ⬆️
centos_x86_64 52.08% <100.00%> (+6.17%) ⬆️
ubuntu_aarch64 52.20% <100.00%> (+6.19%) ⬆️
ubuntu_x86_64 52.19% <100.00%> (+6.19%) ⬆️
windows_amd64 55.80% <100.00%> (+4.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dd-devflow
Copy link

dd-devflow bot commented May 31, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 13 builds ahead! (estimated merge in less than 6h)

Use /merge -c to cancel this operation!

@pr-commenter
Copy link

pr-commenter bot commented May 31, 2024

Regression Detector

Regression Detector Results

Run ID: e3439efa-4414-491d-b2a6-680c14f0ae86
Baseline: d407c3d
Comparison: c93e538

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
basic_py_check % cpu utilization +2.19 [-0.74, +5.11]
pycheck_1000_100byte_tags % cpu utilization +2.16 [-2.43, +6.74]
otel_to_otel_logs ingress throughput +0.04 [-0.32, +0.39]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
trace_agent_msgpack ingress throughput -0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.01 [-0.21, +0.19]
tcp_dd_logs_filter_exclude ingress throughput -0.05 [-0.09, +0.00]
idle memory utilization -0.24 [-0.28, -0.19]
uds_dogstatsd_to_api_cpu % cpu utilization -0.71 [-3.73, +2.30]
file_tree memory utilization -1.89 [-2.01, -1.77]
tcp_syslog_to_blackhole ingress throughput -7.13 [-27.71, +13.45]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dd-mergequeue dd-mergequeue bot merged commit e41596d into main May 31, 2024
240 of 241 checks passed
@dd-mergequeue dd-mergequeue bot deleted the will/enable-dump-suppression branch May 31, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants