Fix windows system-probe pprof flare tests

[hmahmood]

What does this PR do?

Fix failures of TestCommandTestSuite on Windows. We now use shared test servers for all the tests in the suite instead of each test creating its own servers. This is because the RemoteSystemProbeUtil instance used by the tested code is a global and configured only once; creating a server in every test means that the new server config (e.g., the listening port) is not propagated to the ReomteSystemProbeUtil global instance, causing the failure.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=35506753 --os-family=ubuntu

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.53%. Comparing base (696595c) to head (626819a).
Report is 5 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #26150       +/-   ##
===========================================
- Coverage   45.16%   34.53%   -10.63%     
===========================================
  Files        2346       45     -2301     
  Lines      270606     4039   -266567     
===========================================
- Hits       122219     1395   -120824     
+ Misses     138731     2591   -136140     
+ Partials     9656       53     -9603     

Flag	Coverage Δ
amzn_aarch64	34.04% <ø> (-11.95%)	⬇️
centos_x86_64	34.04% <ø> (-11.86%)	⬇️
ubuntu_aarch64	34.04% <ø> (-11.95%)	⬇️
ubuntu_x86_64	34.04% <ø> (-11.94%)	⬇️
windows_amd64	34.21% <ø> (-17.17%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: cdf8979f-d584-4af6-804a-0207022183a9
Baseline: 696595c
Comparison: 626819a

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	pycheck_1000_100byte_tags	% cpu utilization	+2.05	[-2.84, +6.95]
➖	basic_py_check	% cpu utilization	+0.03	[-2.87, +2.93]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.03	[-0.01, +0.06]
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.20, +0.20]
➖	trace_agent_msgpack	ingress throughput	+0.00	[-0.00, +0.00]
➖	trace_agent_json	ingress throughput	-0.01	[-0.04, +0.01]
➖	otel_to_otel_logs	ingress throughput	-0.06	[-0.42, +0.30]
➖	idle	memory utilization	-0.09	[-0.14, -0.05]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.41	[-3.42, +2.60]
➖	file_tree	memory utilization	-1.30	[-1.43, -1.16]
➖	tcp_syslog_to_blackhole	ingress throughput	-4.38	[-25.59, +16.82]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[hmahmood]

/merge

[dd-devflow]

🚂 MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 53m)

Use /merge -c to cancel this operation!