Decrease database instance collection interval

[jmeunier28]

What does this PR do?

This is to help with cases where we see customers sometimes suffer from flapping host tags due to the db instance resource expiring. We should just send them more often to make this less likely.

Motivation

follow up from DataDog/integrations-core#17676 and DataDog/integrations-core#17677

[eric-weaver]

Hm @jmeunier28 Do we need to adjust this value as well? Seems potentially related 🤔

datadog-agent/pkg/collector/corechecks/oracle/oracle.go

Line 185 in a0fd230

dbInstanceIntervalExpired := checkIntervalExpired(&c.dbInstanceLastRun, 1800)

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=35484622 --os-family=ubuntu

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.35%. Comparing base (a0fd230) to head (13e59a4).
Report is 15 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #26142       +/-   ##
===========================================
- Coverage   45.14%   29.35%   -15.80%     
===========================================
  Files        2345       64     -2281     
  Lines      270462     5887   -264575     
===========================================
- Hits       122113     1728   -120385     
+ Misses     138703     4099   -134604     
+ Partials     9646       60     -9586     

Flag	Coverage Δ
amzn_aarch64	28.69% <ø> (-17.29%)	⬇️
centos_x86_64	28.69% <ø> (-17.20%)	⬇️
ubuntu_aarch64	28.69% <ø> (-17.29%)	⬇️
ubuntu_x86_64	28.69% <ø> (-17.28%)	⬇️
windows_amd64	32.12% <ø> (-19.25%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 91f0d6ba-41da-42ca-b008-759b5d2096fb
Baseline: a0fd230
Comparison: 13e59a4

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	file_tree	memory utilization	+0.23	[+0.11, +0.35]
➖	otel_to_otel_logs	ingress throughput	+0.02	[-0.35, +0.39]
➖	trace_agent_msgpack	ingress throughput	+0.02	[+0.00, +0.03]
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.20, +0.21]
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.04, +0.05]
➖	trace_agent_json	ingress throughput	-0.00	[-0.01, +0.01]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.15	[-3.12, +2.83]
➖	idle	memory utilization	-0.21	[-0.25, -0.17]
➖	pycheck_1000_100byte_tags	% cpu utilization	-0.54	[-5.05, +3.97]
➖	basic_py_check	% cpu utilization	-2.22	[-5.15, +0.71]
➖	tcp_syslog_to_blackhole	ingress throughput	-6.23	[-27.69, +15.23]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[jmeunier28]

/merge

[dd-devflow]

🚂 MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!