USM: ssl: Ignore ELF files for other architectures (#25505) #25936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* USM: ssl: Ignore ELF files for other architectures Ignore ELF files which are not for the architecture we're running on. Without this, we could end up installing a uprobe on, for example, an arm64 binary on an amd64 machine, thus corrupting the arm64 instruction and leading to segmentation faults. * Use blockList in test * Use OpenFromAnotherProcess instead of libmmap * Remove unused libmmap * Simplify testArch * Skip test on unsupported platforms * Format fakessl.c with clang-format * Add shebang link to script * Move libs to testdata So that kmt will copy it to the VMs. (cherry picked from commit a6c060e) Conflicts: pkg/network/usm/utils/debugger.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore ELF files which are not for the architecture we're running on. Without this, we could end up installing a uprobe on, for example, an arm64 binary on an amd64 machine, thus corrupting the arm64 instruction and leading to segmentation faults.
Use blockList in test
Use OpenFromAnotherProcess instead of libmmap
Remove unused libmmap
Simplify testArch
Skip test on unsupported platforms
Format fakessl.c with clang-format
Add shebang link to script
Move libs to testdata
So that kmt will copy it to the VMs.
(cherry picked from commit a6c060e)
Conflicts:
pkg/network/usm/utils/debugger.go
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes