Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport][7.53.x] fix exitCode type #25770

Closed
wants to merge 1 commit into from
Closed

Conversation

kangyili
Copy link
Contributor

@kangyili kangyili commented May 21, 2024

What does this PR do?

The bug is introduced by #23248

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@pr-commenter
Copy link

pr-commenter bot commented May 21, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=34744044 --os-family=ubuntu

@pr-commenter
Copy link

pr-commenter bot commented May 21, 2024

Regression Detector

Regression Detector Results

Run ID: 58a31c5f-8931-447a-b999-1384b6e0c269
Baseline: 5e64aaa
Comparison: 005f3b0

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +21.28 [+15.74, +26.82]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +21.28 [+15.74, +26.82]
pycheck_1000_100byte_tags % cpu utilization +1.41 [-3.05, +5.87]
tcp_syslog_to_blackhole ingress throughput +1.26 [-20.14, +22.66]
process_agent_real_time_mode memory utilization +0.78 [+0.74, +0.82]
file_tree memory utilization +0.47 [+0.35, +0.59]
process_agent_standard_check memory utilization +0.44 [+0.38, +0.51]
basic_py_check % cpu utilization +0.43 [-1.95, +2.82]
process_agent_standard_check_with_stats memory utilization +0.20 [+0.15, +0.26]
otel_to_otel_logs ingress throughput +0.07 [-0.30, +0.44]
uds_dogstatsd_to_api ingress throughput +0.01 [-0.20, +0.21]
trace_agent_json ingress throughput +0.00 [-0.01, +0.01]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.04, +0.04]
trace_agent_msgpack ingress throughput -0.02 [-0.02, -0.01]
uds_dogstatsd_to_api_cpu % cpu utilization -0.20 [-3.05, +2.66]
idle memory utilization -0.28 [-0.32, -0.24]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@kangyili kangyili force-pushed the kangyi/fix-exitCode branch from 6accf85 to 5bf7ff4 Compare May 21, 2024 12:48
@kangyili kangyili added this to the no-mile milestone May 21, 2024
@kangyili kangyili marked this pull request as ready for review May 21, 2024 12:50
@kangyili kangyili requested a review from a team as a code owner May 21, 2024 12:50
@kangyili kangyili changed the title fix exitCode type [backport] fix exitCode type May 21, 2024
Copy link
Member

@L3n41c L3n41c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reference in this backport PR the corresponding main PR ?

pkg/util/ecs/metadata/v3or4/client_test.go Outdated Show resolved Hide resolved
@kangyili kangyili mentioned this pull request May 21, 2024
@kangyili kangyili force-pushed the kangyi/fix-exitCode branch from 5bf7ff4 to 005f3b0 Compare May 21, 2024 15:28
@kangyili kangyili changed the title [backport] fix exitCode type [backport][7.53.x] fix exitCode type May 21, 2024
@kangyili kangyili closed this May 23, 2024
@dd-devflow dd-devflow bot deleted the kangyi/fix-exitCode branch November 21, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants