Run inv install-tools and inv dowload-tools as part of inv setup

[FlorentClarret]

What does this PR do?

Run inv install-tools and inv dowload-tools as part of inv setup

Motivation

@ogaca-dd told me it would be useful!

Additional Notes

Output:

❯ inv setup
Checking Python version...
Checking Go version...
Fetching git repository...
Checking main branch...
Updating Python dependencies...
Updating Python dependencies from requirements.txt...
Updating Python dependencies from tasks/requirements.txt...
Downloading go tools...
Installing go tools...
Enabling pre-commit...

Results:

Check Python version     OK
Check Go version         OK
Check git repository     WARN
Your branch is 1 commit(s) behind main. Please update your branch.
Update Python dependencies from requirements.txt         OK
Update Python dependencies from tasks/requirements.txt   OK
Download Go tools        OK
Install Go tools         OK
Enable pre-commit        OK

Setup completed with warnings.

With an error:

❯ inv setup
Checking Python version...
Checking Go version...
Fetching git repository...
Checking main branch...
Updating Python dependencies...
Updating Python dependencies from requirements.txt...
Updating Python dependencies from tasks/requirements.txt...
Downloading go tools...
Installing go tools...
Enabling pre-commit...

Results:

Check Python version     OK
Check Go version         OK
Check git repository     WARN
Your branch is 1 commit(s) behind main. Please update your branch.
Update Python dependencies from requirements.txt         OK
Update Python dependencies from tasks/requirements.txt   OK
Download Go tools        OK
Install Go tools         FAIL
package githubcom/frapposelli/wwhrd is not in std (/opt/homebrew/Cellar/[email protected]/1.21.10/libexec/src/githubcom/frapposelli/wwhrd)
Enable pre-commit        OK

Setup completed with errors.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[CelianR]

LGTM, 👏 thanks for the refactoring !

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 34441156 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 7297d812-9ee7-43d3-8d6f-50103224a685
Baseline: 074cf38
Comparison: 1b58e8a

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	pycheck_1000_100byte_tags	% cpu utilization	+1.70	[-3.16, +6.57]
➖	file_tree	memory utilization	+0.13	[+0.02, +0.24]
➖	idle	memory utilization	+0.11	[+0.07, +0.15]
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.20, +0.21]
➖	trace_agent_json	ingress throughput	+0.00	[-0.01, +0.01]
➖	trace_agent_msgpack	ingress throughput	+0.00	[-0.00, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.02	[-0.07, +0.02]
➖	otel_to_otel_logs	ingress throughput	-0.04	[-0.40, +0.33]
➖	basic_py_check	% cpu utilization	-0.24	[-2.87, +2.39]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.31	[-3.21, +2.59]
➖	tcp_syslog_to_blackhole	ingress throughput	-6.16	[-27.03, +14.70]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".