-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cluster-agent] Fix CWS Instrumentation metrics #25433
Conversation
7b563ef
to
9e2d19b
Compare
[Fast Unit Tests Report] On pipeline 33786799 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience |
9e2d19b
to
5e80d88
Compare
/merge |
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=33786799 --os-family=ubuntu |
🚂 MergeQueue Pull request added to the queue. There are 2 builds ahead! (estimated merge in less than 1h) Use |
(cherry picked from commit a26c9f8)
(cherry picked from commit a26c9f8) Co-authored-by: Guillaume Fournier <[email protected]>
What does this PR do?
This PR fixes the metrics generated for CWS Instrumentation. Instead of using a counter that will grow forever, a distribution will better fit our monitoring use case.
Motivation
This fixes our visibility on the
kubectl cp
instrumentation feature added in this PR.