Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cluster-agent] Fix CWS Instrumentation metrics #25433

Merged
merged 1 commit into from
May 7, 2024

Conversation

Gui774ume
Copy link
Contributor

What does this PR do?

This PR fixes the metrics generated for CWS Instrumentation. Instead of using a counter that will grow forever, a distribution will better fit our monitoring use case.

Motivation

This fixes our visibility on the kubectl cp instrumentation feature added in this PR.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 7, 2024

[Fast Unit Tests Report]

On pipeline 33786799 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@Gui774ume Gui774ume force-pushed the will/fix-cws-instrumentation-metrics branch from 9e2d19b to 5e80d88 Compare May 7, 2024 15:51
@Gui774ume
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 7, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@pr-commenter
Copy link

pr-commenter bot commented May 7, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=33786799 --os-family=ubuntu

@dd-devflow
Copy link

dd-devflow bot commented May 7, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit a26c9f8 into main May 7, 2024
195 of 196 checks passed
@dd-mergequeue dd-mergequeue bot deleted the will/fix-cws-instrumentation-metrics branch May 7, 2024 17:45
agent-platform-auto-pr bot pushed a commit that referenced this pull request May 7, 2024
Gui774ume added a commit that referenced this pull request May 7, 2024
(cherry picked from commit a26c9f8)

Co-authored-by: Guillaume Fournier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants