add caching of minimized BTFs #25283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycekahle
added
changelog/no-changelog
team/ebpf-platform
qa/done
spencergilbert
approved these changes
May 1, 2024
chouetz
approved these changes
May 2, 2024
usamasaqib
approved these changes
May 2, 2024
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. There are 10 builds ahead! (estimated merge in less than 5h) Use |
gjulianm
pushed a commit
that referenced
this pull request
Dec 4, 2024
* add caching of minimized BTFs * add --region * fix brackets * use abs path for download * don't need brackets for command
gjulianm
pushed a commit
that referenced
this pull request
Dec 11, 2024
* add caching of minimized BTFs * add --region * fix brackets * use abs path for download * don't need brackets for command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Caches minimized BTFs on S3. The bucket used has automatic cleanup after 7 days.
Motivation
Speed up pipelines, due to BTF minimization taking longer after the introduction of kernel module BTF data.
Additional Notes
The cache key is based on two things:
ETagfrom the processed btfhub-archive tarball in S3. This will change as new BTF data is introduced to btfhub-archive, and that data is processed in thebuild_processed_btfhub_archivejob that runs nightly.The cache is skipped if you set
RUN_ALL_BUILDSor a release branch is being used. This is to prevent potential cache-related issues in released artifacts.https://datadoghq.atlassian.net/browse/EBPF-495
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes