Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lint-licenses] Handled non utf8 errors #25045

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

CelianR
Copy link
Contributor

@CelianR CelianR commented Apr 24, 2024

What does this PR do?

Fixes issue with some licenses containing non-utf8 characters (as in this job).

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@CelianR CelianR added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-ci-experience labels Apr 24, 2024
@CelianR CelianR self-assigned this Apr 24, 2024
@CelianR CelianR requested review from a team as code owners April 24, 2024 08:36
@CelianR CelianR changed the title [lint-licenses] Handled errors [lint-licenses] Handled non utf8 errors Apr 24, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 32788291 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

Copy link
Member

@amenasria amenasria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

👏 praise: ‏Nice improvement

@pr-commenter
Copy link

pr-commenter bot commented Apr 24, 2024

Regression Detector

Regression Detector Results

Run ID: e8ad996d-a9a7-48e3-8d83-2163bd364f51
Baseline: c04e97b
Comparison: 3d5ace6

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -48.25 [-52.88, -43.61]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
pycheck_1000_100byte_tags % cpu utilization +1.26 [-3.62, +6.14]
uds_dogstatsd_to_api_cpu % cpu utilization +0.85 [-1.93, +3.63]
idle memory utilization +0.30 [+0.26, +0.33]
process_agent_standard_check memory utilization +0.17 [+0.11, +0.22]
process_agent_standard_check_with_stats memory utilization +0.06 [+0.01, +0.11]
trace_agent_msgpack ingress throughput +0.01 [-0.00, +0.01]
otel_to_otel_logs ingress throughput -0.00 [-0.35, +0.35]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.03, +0.02]
trace_agent_json ingress throughput -0.01 [-0.02, +0.01]
process_agent_real_time_mode memory utilization -0.81 [-0.85, -0.77]
basic_py_check % cpu utilization -1.20 [-3.63, +1.23]
tcp_syslog_to_blackhole ingress throughput -5.70 [-26.25, +14.86]
file_to_blackhole % cpu utilization -48.25 [-52.88, -43.61]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@CelianR
Copy link
Contributor Author

CelianR commented Apr 24, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 24, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Apr 24, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 2 builds ahead! (estimated merge in less than 1h)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 237078e into main Apr 24, 2024
203 of 205 checks passed
@dd-mergequeue dd-mergequeue bot deleted the celian/licenses-lint-errors branch April 24, 2024 15:29
@github-actions github-actions bot added this to the 7.54.0 milestone Apr 24, 2024
alexgallotta pushed a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-ci-experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants