Add logsagentpipeline component for OTLP ingest paths #25032

liustanley · 2024-04-23T20:08:44Z

What does this PR do?

This PR adds logs agent setup files in comp/otelcol/logsagentpipeline. This includes agent.go which mirrors the logs agent initialization files in comp/logs/agent, with only the pipeline components that are needed for OTLP ingest paths (otel-agent and collector datadog exporter).

This PR also modifies the otel-agent run subcommand to use logsagentpipeline instead of the logs agent in comp/logs/agent.

Motivation

This code was initially added to collector-contrib in this PR: open-telemetry/opentelemetry-collector-contrib#32327, but needs to be added in datadog-agent instead to be used by the otel-agent.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

comp/otelcol/otlp/components/logsagentpipeline/agent_core_init.go

gh123man

I don't see any obvious issues with how this is set up. so LGTM 👍
Just made a couple of small suggestions.

you may also consider renaming these files to be more otel specific - up to you though.

comp/otelcol/otlp/components/logsagentpipeline/agent.go

comp/otelcol/otlp/components/logsagentpipeline/agent_core_init.go

pr-commenter · 2024-04-23T21:34:25Z

Regression Detector

Regression Detector Results

Run ID: 6ff0dc23-18a7-4f33-a65d-23249d8f91da
Baseline: 9581bfe
Comparison: 8c8d4b3

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI
❌	file_to_blackhole	% cpu utilization	+15.13	[+8.96, +21.30]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
❌	file_to_blackhole	% cpu utilization	+15.13	[+8.96, +21.30]
➖	basic_py_check	% cpu utilization	+2.09	[-0.51, +4.70]
➖	idle	memory utilization	+0.32	[+0.29, +0.36]
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.19, +0.22]
➖	trace_agent_json	ingress throughput	+0.01	[-0.01, +0.02]
➖	otel_to_otel_logs	ingress throughput	-0.00	[-0.36, +0.35]
➖	trace_agent_msgpack	ingress throughput	-0.01	[-0.02, -0.00]
➖	process_agent_standard_check_with_stats	memory utilization	-0.05	[-0.10, +0.00]
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.06	[-0.10, -0.02]
➖	process_agent_real_time_mode	memory utilization	-0.24	[-0.27, -0.20]
➖	process_agent_standard_check	memory utilization	-0.25	[-0.31, -0.20]
➖	file_tree	memory utilization	-0.47	[-0.56, -0.37]
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.11	[-3.90, +1.67]
➖	pycheck_1000_100byte_tags	% cpu utilization	-1.31	[-6.06, +3.45]
➖	tcp_syslog_to_blackhole	ingress throughput	-7.72	[-28.09, +12.66]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

cit-pr-commenter · 2024-04-24T15:26:21Z

Go Package Import Differences

Baseline: 9581bfe
Comparison: 8c8d4b3

binary	os	arch	change
agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline
agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline
agent	windows	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline
agent	windows	386	+1, -0 +github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline
agent	darwin	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline
agent	darwin	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline
iot-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline
iot-agent	linux	arm64	+1, -0 +github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline
heroku-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline

pr-commenter · 2024-04-24T17:55:40Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=33063667 --os-family=ubuntu

cmd/agent/subcommands/run/command.go

dustmop

LGTM

CelianR

Lgtm for agent ci experience files 👍

comp/otelcol/logsagentpipeline/component.go

comp/otelcol/logsagentpipeline/logsagentpipelineimpl/agent.go

liustanley · 2024-04-26T17:39:25Z

/merge

dd-devflow · 2024-04-26T17:39:32Z

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

dd-devflow · 2024-04-26T21:15:06Z

🚂 MergeQueue

Pull request added to the queue.

There are 6 builds ahead! (estimated merge in less than 3h)

Use /merge -c to cancel this operation!

* Add logs agent pipeline files * Add modules * Replace logs agent in otel-agent with logs agent pipeline * Fix dependency version * Add health liveness * PR feedback * Move component * Fix otel-agent * Fix lint * Fix imports * Make dependencies public * Fix lint * Edit component interface * Fix fx * Rename method * Update comments * Fix license year * Fix go mods * Fix lint

liustanley added 5 commits April 23, 2024 15:59

Add logs agent pipeline files

c31e58c

Add modules

c581a66

Replace logs agent in otel-agent with logs agent pipeline

0426beb

Fix dependency version

ba57a73

Add health liveness

c5aba8e

liustanley added changelog/no-changelog team/opentelemetry OpenTelemetry team labels Apr 23, 2024

liustanley requested review from a team as code owners April 23, 2024 20:08

liustanley requested a review from mx-psi April 23, 2024 20:08

liustanley added this to the 7.54.0 milestone Apr 23, 2024

liustanley commented Apr 23, 2024

View reviewed changes

comp/otelcol/otlp/components/logsagentpipeline/agent_core_init.go Outdated Show resolved Hide resolved

gh123man self-requested a review April 23, 2024 20:20

liustanley requested review from truthbk and dustmop April 23, 2024 20:21

gh123man reviewed Apr 23, 2024

View reviewed changes

comp/otelcol/otlp/components/logsagentpipeline/agent.go Outdated Show resolved Hide resolved

comp/otelcol/otlp/components/logsagentpipeline/agent_core_init.go Outdated Show resolved Hide resolved

liustanley added 3 commits April 24, 2024 10:08

PR feedback

2faafce

Move component

d8a3606

Fix otel-agent

d934a6c

liustanley requested a review from a team as a code owner April 24, 2024 15:07

liustanley added 2 commits April 24, 2024 11:15

Fix lint

a7ba8f1

Fix imports

cab6b2c

liustanley added 4 commits April 24, 2024 11:33

Make dependencies public

895ff29

Fix lint

f966dae

Merge branch 'main' into stanley.liu/logsagentpipeline

15395e8

Edit component interface

8597dd4

liustanley added 3 commits April 24, 2024 15:11

Fix fx

db1db52

Rename method

dfe3913

Update comments

a3a7bf7

liustanley mentioned this pull request Apr 24, 2024

[exporter/datadog] Refactor Datadog Exporter to use logs agent exporter open-telemetry/opentelemetry-collector-contrib#32327

Merged

liustanley requested review from dineshg13 and removed request for mx-psi April 24, 2024 19:43

dustmop reviewed Apr 24, 2024

View reviewed changes

cmd/agent/subcommands/run/command.go Show resolved Hide resolved

dustmop approved these changes Apr 24, 2024

View reviewed changes

CelianR approved these changes Apr 25, 2024

View reviewed changes

comp/otelcol/logsagentpipeline/component.go Outdated Show resolved Hide resolved

comp/otelcol/logsagentpipeline/logsagentpipelineimpl/agent.go Outdated Show resolved Hide resolved

Fix license year

3a57d24

dineshg13 approved these changes Apr 25, 2024

View reviewed changes

liustanley added 2 commits April 26, 2024 13:33

Merge branch 'main' into stanley.liu/logsagentpipeline

3219d58

Fix go mods

636c621

Fix lint

8c8d4b3

dd-devflow bot mentioned this pull request Apr 26, 2024

(fleet) fix remote updates permissions #25170

Merged

dd-mergequeue bot merged commit a1ef7ed into main Apr 26, 2024
195 of 196 checks passed

dd-mergequeue bot deleted the stanley.liu/logsagentpipeline branch April 26, 2024 23:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add logsagentpipeline component for OTLP ingest paths #25032

Add logsagentpipeline component for OTLP ingest paths #25032

liustanley commented Apr 23, 2024 •

edited

Loading

gh123man left a comment

pr-commenter bot commented Apr 23, 2024 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

cit-pr-commenter bot commented Apr 24, 2024 •

edited

Loading

pr-commenter bot commented Apr 24, 2024 •

edited

Loading

dustmop left a comment

CelianR left a comment

liustanley commented Apr 26, 2024

dd-devflow bot commented Apr 26, 2024

dd-devflow bot commented Apr 26, 2024

Add logsagentpipeline component for OTLP ingest paths #25032

Add logsagentpipeline component for OTLP ingest paths #25032

Conversation

liustanley commented Apr 23, 2024 • edited Loading

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

gh123man left a comment

Choose a reason for hiding this comment

pr-commenter bot commented Apr 23, 2024 • edited Loading

Regression Detector

Regression Detector Results

No significant changes in experiment optimization goals

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

cit-pr-commenter bot commented Apr 24, 2024 • edited Loading

Go Package Import Differences

pr-commenter bot commented Apr 24, 2024 • edited Loading

Test changes on VM

dustmop left a comment

Choose a reason for hiding this comment

CelianR left a comment

Choose a reason for hiding this comment

liustanley commented Apr 26, 2024

dd-devflow bot commented Apr 26, 2024

dd-devflow bot commented Apr 26, 2024

liustanley commented Apr 23, 2024 •

edited

Loading

pr-commenter bot commented Apr 23, 2024 •

edited

Loading

cit-pr-commenter bot commented Apr 24, 2024 •

edited

Loading

pr-commenter bot commented Apr 24, 2024 •

edited

Loading