Sets gomaxprocs in core agent before components initialize #25021
Conversation
…orker calculation
scottopell
added
changelog/no-changelog
team/single-machine-performance
Co-authored-by: Vickenty Fesunov <[email protected]>
|
/merge |
|
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=32733047 --os-family=ubuntu |
|
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 49m) Use |
| @@ -307,6 +304,15 @@ func run(log log.Component, | |||
|
|
|||
| func getSharedFxOption() fx.Option { | |||
| return fx.Options( | |||
| fx.Invoke(func(lc fx.Lifecycle) { | |||
There was a problem hiding this comment.
ddruntime.SetMaxProcs() is called after every component constructor and after OnStart hooks. I guess this function should be called as earlier as possible. What do you think?
There was a problem hiding this comment.
This is a good point, I didn't realize that this won't run before other component's constructors, which would be desirable (although not necessary for the specific bug I'm working around here).
If you can offer a suggested way to run this as early as possible, but still have access to logger, I'd be happy to submit a follow-up to improve this.
There was a problem hiding this comment.
One option is to replace
return fxutil.OneShot(run,
fx.Supply(core.BundleParams{by
return fxutil.OneShot(run,
fx.Invoke(func(_ log.Component) {
ddruntime.SetMaxProcs()
}),
fx.Supply(core.BundleParams{There was a problem hiding this comment.
Thanks for the suggestion, I tested this and it works as expected. Available for review in #25198
* Sets gomaxprocs before other components initialize and logs out dsd worker calculation * Update pkg/aggregator/demultiplexer.go Co-authored-by: Vickenty Fesunov <[email protected]> --------- Co-authored-by: Vickenty Fesunov <[email protected]>
What does this PR do?
This reorders the core agent startup so that the custom logic we have for setting
GOMAXPROCSwill always finish before any other component initializes.Motivation
Components can and do (see dogstatsd) use the value of
GOMAXPROCSto make decisions about how many of a certain component to run.If the
GOMAXPROCSenv var is set using a millicore suffix as is supported by the Agent, this currently races against component initialization (and loses in practice).Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
QA Done locally, confirmed that GOMAXPROCS is set correctly and core agent runs properly.