Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the buildimages #24796

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Bump the buildimages #24796

merged 1 commit into from
Apr 18, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Apr 18, 2024

What does this PR do?

Bump the buildimages

Motivation

Make use of:

Additional Notes

Last PR related to https://datadoghq.atlassian.net/browse/ADXT-186

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@FlorentClarret FlorentClarret requested a review from a team as a code owner April 18, 2024 09:10
@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Apr 18, 2024
@FlorentClarret FlorentClarret added this to the 7.54.0 milestone Apr 18, 2024
@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 18, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 32377423 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@dd-devflow
Copy link

dd-devflow bot commented Apr 18, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 25m)

Use /merge -c to cancel this operation!

@pr-commenter
Copy link

pr-commenter bot commented Apr 18, 2024

Regression Detector

Regression Detector Results

Run ID: c5532eb0-4ecc-41ef-976c-557bf5794360
Baseline: b0d6c2d
Comparison: 1e8b259

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +2.39 [-3.32, +8.10]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +2.39 [-3.32, +8.10]
basic_py_check % cpu utilization +0.81 [-1.91, +3.53]
process_agent_standard_check memory utilization +0.60 [+0.54, +0.66]
tcp_syslog_to_blackhole ingress throughput +0.51 [+0.43, +0.59]
uds_dogstatsd_to_api_cpu % cpu utilization +0.33 [-2.68, +3.35]
otel_to_otel_logs ingress throughput +0.11 [-0.32, +0.53]
idle memory utilization +0.10 [+0.06, +0.15]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.03, +0.04]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.21, +0.20]
trace_agent_json ingress throughput -0.01 [-0.02, +0.01]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.00]
process_agent_real_time_mode memory utilization -0.14 [-0.19, -0.09]
process_agent_standard_check_with_stats memory utilization -0.71 [-0.76, -0.65]
pycheck_1000_100byte_tags % cpu utilization -0.94 [-5.87, +3.99]
file_tree memory utilization -1.19 [-1.32, -1.06]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dd-mergequeue dd-mergequeue bot merged commit 49cb38b into main Apr 18, 2024
243 of 246 checks passed
@dd-mergequeue dd-mergequeue bot deleted the florentclarret/bump_build_image branch April 18, 2024 11:17
CelianR pushed a commit that referenced this pull request Apr 26, 2024
alexgallotta pushed a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants