Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incident-26767] disable TestEKSSuite #24759

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

pducolin
Copy link
Contributor

What does this PR do?

Skip TestEKSSuite

Motivation

This test is failing ~28% of the times - see in Test Runs

Let's stabilise main by reducing the impact of this test, while we work on a fix

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@pducolin pducolin added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Apr 17, 2024
@pducolin pducolin requested a review from a team as a code owner April 17, 2024 07:25
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 32277442 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented Apr 17, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=32277442 --os-family=ubuntu

@pducolin
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 17, 2024

🚂 MergeQueue

Pull request added to the queue.

There are 3 builds ahead! (estimated merge in less than 2h)

Use /merge -c to cancel this operation!

@pr-commenter
Copy link

pr-commenter bot commented Apr 17, 2024

Regression Detector

Regression Detector Results

Run ID: dfcb8683-0c4d-4e63-a77c-8dfe9061ab70
Baseline: e68edd1
Comparison: 3c40699

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -1.72 [-7.56, +4.11]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +0.73 [+0.60, +0.85]
tcp_syslog_to_blackhole ingress throughput +0.70 [+0.63, +0.78]
process_agent_real_time_mode memory utilization +0.53 [+0.49, +0.58]
uds_dogstatsd_to_api_cpu % cpu utilization +0.47 [-2.54, +3.49]
otel_to_otel_logs ingress throughput +0.46 [+0.01, +0.91]
process_agent_standard_check_with_stats memory utilization +0.26 [+0.21, +0.30]
trace_agent_json ingress throughput +0.01 [-0.02, +0.03]
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.02, +0.03]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
trace_agent_msgpack ingress throughput -0.01 [-0.02, -0.00]
process_agent_standard_check memory utilization -0.16 [-0.22, -0.11]
basic_py_check % cpu utilization -0.58 [-3.29, +2.12]
idle memory utilization -0.70 [-0.74, -0.65]
pycheck_1000_100byte_tags % cpu utilization -1.41 [-6.31, +3.48]
file_to_blackhole % cpu utilization -1.72 [-7.56, +4.11]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dd-mergequeue dd-mergequeue bot merged commit 03e93c7 into main Apr 17, 2024
200 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pducolin/skip-eks-dockerhub-rate-limit branch April 17, 2024 09:05
@github-actions github-actions bot added this to the 7.54.0 milestone Apr 17, 2024
CelianR pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants