-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore sysvinit scripts when systemd is used #2469
Conversation
89d33a6
to
b4367fe
Compare
systemctl enable $SERVICE_NAME || echo "[ WARNING ]\tCannot enable $SERVICE_NAME with systemctl" | ||
systemctl enable $SERVICE_NAME-process || echo "[ WARNING ]\tCannot enable $SERVICE_NAME-process with systemctl" | ||
systemctl enable $SERVICE_NAME-trace || echo "[ WARNING ]\tCannot enable $SERVICE_NAME-trace with systemctl" | ||
SYSTEMCTL_SKIP_SYSV=true systemctl enable $SERVICE_NAME || echo "[ WARNING ]\tCannot enable $SERVICE_NAME with systemctl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a small comment explaining why we need SYSTEMCTL_SKIP_SYSV=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sure
what's the warning? Some customers use the |
Something like this:
But they also appear when enabling are disabling core system services like |
@remicalixte ok, thanks for the info. I could still see these warnings confuse some users (they look a bit worrying TBH). Could you update the release note on the |
@olivielpeau the public docs on debian advice to use the |
@remicalixte you can double-check on the docs available on this repo as well, but that's all I can think of 👍 |
19ac23f
to
d588876
Compare
Missed some docs mentioning sysvinit on this repo |
What does this PR do?
use
SYSTEMCTL_SKIP_SYSV
env varMotivation
Remove irrelevant warning on install