Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/new-e2e/tests/apm: root tag e2e test #24618

Merged
merged 7 commits into from
Apr 13, 2024
Merged

Conversation

simont1
Copy link
Contributor

@simont1 simont1 commented Apr 11, 2024

What does this PR do?

This PR is to add the e2e test for this PR

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@github-actions github-actions bot added the team/agent-apm trace-agent label Apr 11, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Apr 11, 2024

[Fast Unit Tests Report]

On pipeline 32058133 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented Apr 11, 2024

Regression Detector

Regression Detector Results

Run ID: 270b2957-403f-4d35-9b2e-0847d70d672a
Baseline: 1f33b61
Comparison: dc37d32

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.47 [-4.33, +7.28]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.47 [-4.33, +7.28]
pycheck_1000_100byte_tags % cpu utilization +1.31 [-3.64, +6.27]
process_agent_real_time_mode memory utilization +0.35 [+0.30, +0.39]
otel_to_otel_logs ingress throughput +0.25 [-0.17, +0.68]
idle memory utilization +0.08 [+0.03, +0.12]
trace_agent_json ingress throughput +0.02 [-0.01, +0.05]
process_agent_standard_check memory utilization +0.02 [-0.03, +0.07]
tcp_dd_logs_filter_exclude ingress throughput +0.02 [-0.02, +0.05]
trace_agent_msgpack ingress throughput -0.01 [-0.03, +0.01]
uds_dogstatsd_to_api ingress throughput -0.02 [-0.22, +0.19]
process_agent_standard_check_with_stats memory utilization -0.14 [-0.19, -0.10]
tcp_syslog_to_blackhole ingress throughput -0.22 [-0.29, -0.14]
file_tree memory utilization -0.26 [-0.38, -0.14]
basic_py_check % cpu utilization -0.38 [-2.89, +2.14]
uds_dogstatsd_to_api_cpu % cpu utilization -0.77 [-3.71, +2.17]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pr-commenter
Copy link

pr-commenter bot commented Apr 11, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=32058133 --os-family=ubuntu

@simont1 simont1 marked this pull request as ready for review April 11, 2024 21:05
@simont1 simont1 requested a review from a team as a code owner April 11, 2024 21:05
@knusbaum knusbaum added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Apr 12, 2024
@knusbaum knusbaum force-pushed the simont1/root-tag-e2e-test branch from 657e8c0 to e1346a1 Compare April 12, 2024 19:28
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, LGTM.

@knusbaum
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 13, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 24m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 42daab7 into main Apr 13, 2024
179 checks passed
@dd-mergequeue dd-mergequeue bot deleted the simont1/root-tag-e2e-test branch April 13, 2024 20:25
@github-actions github-actions bot added this to the 7.54.0 milestone Apr 13, 2024
@ahmed-mez ahmed-mez changed the title Simont1/root tag e2e test test/new-e2e/tests/apm: root tag e2e test Apr 15, 2024
CelianR pushed a commit that referenced this pull request Apr 26, 2024
alexgallotta pushed a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants