Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Run docker fake intake test with new version of the fakeintake if mod…"" #24587

Conversation

KevinFairise2
Copy link
Member

Reverts #24586

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 31881500 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented Apr 11, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=31881500 --os-family=ubuntu

@pr-commenter
Copy link

pr-commenter bot commented Apr 11, 2024

Regression Detector

Regression Detector Results

Run ID: dfb904cc-7f4d-49a7-81a1-88ad5b52fb1a
Baseline: ffb080b
Comparison: 69cb600

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.47 [-4.02, +6.97]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.47 [-4.02, +6.97]
uds_dogstatsd_to_api_cpu % cpu utilization +0.89 [-2.13, +3.91]
tcp_syslog_to_blackhole ingress throughput +0.44 [+0.36, +0.52]
process_agent_standard_check_with_stats memory utilization +0.40 [+0.35, +0.46]
otel_to_otel_logs ingress throughput +0.38 [-0.04, +0.81]
process_agent_standard_check memory utilization +0.15 [+0.08, +0.21]
pycheck_1000_100byte_tags % cpu utilization +0.11 [-4.82, +5.05]
trace_agent_msgpack ingress throughput +0.00 [-0.00, +0.00]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.20, +0.20]
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.05, +0.02]
trace_agent_json ingress throughput -0.02 [-0.04, -0.00]
process_agent_real_time_mode memory utilization -0.11 [-0.15, -0.06]
idle memory utilization -0.16 [-0.21, -0.12]
file_tree memory utilization -0.42 [-0.54, -0.30]
basic_py_check % cpu utilization -1.67 [-4.28, +0.95]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@KevinFairise2 KevinFairise2 added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Apr 11, 2024
@KevinFairise2
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 11, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Apr 11, 2024

⚠️ MergeQueue

This merge request was unqueued

If you need support, contact us on Slack #devflow!

@KevinFairise2
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 12, 2024

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Apr 12, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 49m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 6990301 into main Apr 12, 2024
208 checks passed
@dd-mergequeue dd-mergequeue bot deleted the revert-24586-revert-24441-kfairise/e2e-pre-test-with-beta-fakeintake branch April 12, 2024 10:09
@github-actions github-actions bot added this to the 7.54.0 milestone Apr 12, 2024
CelianR pushed a commit that referenced this pull request Apr 26, 2024
…akeintake if mod…"" (#24587)

* Revert "Revert "Run docker fake intake test with new version of the fakeintak…"

This reverts commit ffb080b.

* Remove hyphen
alexgallotta pushed a commit that referenced this pull request May 9, 2024
…akeintake if mod…"" (#24587)

* Revert "Revert "Run docker fake intake test with new version of the fakeintak…"

This reverts commit ffb080b.

* Remove hyphen
chouetz pushed a commit that referenced this pull request Nov 18, 2024
…akeintake if mod…"" (#24587)

* Revert "Revert "Run docker fake intake test with new version of the fakeintak…"

This reverts commit ffb080b.

* Remove hyphen
chouetz pushed a commit that referenced this pull request Nov 18, 2024
…akeintake if mod…"" (#24587)

* Revert "Revert "Run docker fake intake test with new version of the fakeintak…"

This reverts commit ffb080b.

* Remove hyphen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants