Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move signing keys to new ssm names #23924

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Move signing keys to new ssm names #23924

merged 1 commit into from
Mar 20, 2024

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Mar 20, 2024

What does this PR do?

Change the ssm names for main branch

Motivation

Security

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@chouetz chouetz requested a review from a team as a code owner March 20, 2024 12:49
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation backport/7.50.x backport/7.51.x backport/7.52.x automatically create a backport PR to 7.52.x labels Mar 20, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 20, 2024

[Fast Unit Tests Report]

On pipeline 30442262 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented Mar 20, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=30442262 --os-family=ubuntu

@chouetz chouetz merged commit 512937c into main Mar 20, 2024
165 of 170 checks passed
@chouetz chouetz deleted the nschweitzer/ssm branch March 20, 2024 14:56
@github-actions github-actions bot added this to the 7.53.0 milestone Mar 20, 2024
@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.50.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.50.x 7.50.x
# Navigate to the new working tree
cd .worktrees/backport-7.50.x
# Create a new branch
git switch --create backport-23924-to-7.50.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 512937ca3af96ed2f3136f6d8ef7829f29a133aa
# Push it to GitHub
git push --set-upstream origin backport-23924-to-7.50.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.50.x

Then, create a pull request where the base branch is 7.50.x and the compare/head branch is backport-23924-to-7.50.x.

@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.51.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.51.x 7.51.x
# Navigate to the new working tree
cd .worktrees/backport-7.51.x
# Create a new branch
git switch --create backport-23924-to-7.51.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 512937ca3af96ed2f3136f6d8ef7829f29a133aa
# Push it to GitHub
git push --set-upstream origin backport-23924-to-7.51.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.51.x

Then, create a pull request where the base branch is 7.51.x and the compare/head branch is backport-23924-to-7.51.x.

@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.52.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.52.x 7.52.x
# Navigate to the new working tree
cd .worktrees/backport-7.52.x
# Create a new branch
git switch --create backport-23924-to-7.52.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 512937ca3af96ed2f3136f6d8ef7829f29a133aa
# Push it to GitHub
git push --set-upstream origin backport-23924-to-7.52.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.52.x

Then, create a pull request where the base branch is 7.52.x and the compare/head branch is backport-23924-to-7.52.x.

spencergilbert pushed a commit that referenced this pull request Mar 20, 2024
spencergilbert pushed a commit that referenced this pull request Mar 20, 2024
spencergilbert pushed a commit that referenced this pull request Mar 20, 2024
spencergilbert pushed a commit that referenced this pull request Mar 20, 2024
spencergilbert pushed a commit that referenced this pull request Mar 20, 2024
spencergilbert added a commit that referenced this pull request Mar 20, 2024
(cherry picked from commit 512937c)

Co-authored-by: Nicolas Schweitzer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.50.x backport/7.51.x backport/7.52.x automatically create a backport PR to 7.52.x changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants