-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump marocchino/sticky-pull-request-comment from 2.5.0 to 2.9.0 #22590
Bump marocchino/sticky-pull-request-comment from 2.5.0 to 2.9.0 #22590
Conversation
The following labels could not be found: |
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: c15754f0-f083-41e6-aad5-84fc7dc5ff35 Performance changes are noted in the perf column of each table:
Experiments with missing or malformed data
Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration. No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | -0.32 | [-6.87, +6.23] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.04 | [+0.98, +1.10] |
➖ | process_agent_real_time_mode | memory utilization | +0.80 | [+0.75, +0.85] |
➖ | idle | memory utilization | +0.23 | [+0.18, +0.27] |
➖ | process_agent_standard_check | memory utilization | +0.18 | [+0.13, +0.23] |
➖ | otel_to_otel_logs | ingress throughput | +0.09 | [-0.57, +0.76] |
➖ | process_agent_standard_check_with_stats | memory utilization | +0.03 | [-0.02, +0.08] |
➖ | trace_agent_msgpack | ingress throughput | +0.02 | [+0.01, +0.03] |
➖ | trace_agent_json | ingress throughput | +0.01 | [-0.01, +0.02] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | file_to_blackhole | % cpu utilization | -0.32 | [-6.87, +6.23] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.68 | [-2.10, +0.74] |
➖ | file_tree | memory utilization | -1.34 | [-1.44, -1.23] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Bumps [marocchino/sticky-pull-request-comment](https://github.com/marocchino/sticky-pull-request-comment) from 2.5.0 to 2.9.0. - [Release notes](https://github.com/marocchino/sticky-pull-request-comment/releases) - [Commits](marocchino/sticky-pull-request-comment@v2.5.0...v2.9.0) --- updated-dependencies: - dependency-name: marocchino/sticky-pull-request-comment dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dba8513
to
6f5756e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge |
🚂 MergeQueue This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
…pull-request-comment-2.9.0
[Fast Unit Tests Report] On pipeline 31915181 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience |
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 49m) Use |
Regression DetectorRegression Detector ResultsRun ID: 1f6ae77d-3a90-407b-b704-55c41bb17d12 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | file_to_blackhole | % cpu utilization | -0.16 | [-5.61, +5.30] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +1.60 | [-0.87, +4.07] |
➖ | process_agent_standard_check | memory utilization | +0.40 | [+0.35, +0.46] |
➖ | process_agent_standard_check_with_stats | memory utilization | +0.35 | [+0.29, +0.40] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.30 | [-4.64, +5.23] |
➖ | otel_to_otel_logs | ingress throughput | +0.24 | [-0.21, +0.70] |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.19 | [+0.11, +0.27] |
➖ | trace_agent_msgpack | ingress throughput | +0.00 | [-0.00, +0.00] |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.21, +0.20] |
➖ | process_agent_real_time_mode | memory utilization | -0.02 | [-0.06, +0.02] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.03 | [-0.05, -0.01] |
➖ | trace_agent_json | ingress throughput | -0.03 | [-0.06, +0.00] |
➖ | file_to_blackhole | % cpu utilization | -0.16 | [-5.61, +5.30] |
➖ | idle | memory utilization | -0.27 | [-0.31, -0.24] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.57 | [-3.57, +2.42] |
➖ | file_tree | memory utilization | -1.01 | [-1.14, -0.89] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Co-authored-by: duncanpharvey <[email protected]>
Co-authored-by: duncanpharvey <[email protected]>
Bumps marocchino/sticky-pull-request-comment from 2.5.0 to 2.9.0.
Release notes
Sourced from marocchino/sticky-pull-request-comment's releases.
Commits
331f8f5
📦️ build5c844f7
⬆️ node 20989f9fa
Merge pull request #1236 from marocchino/dependabot/npm_and_yarn/typescript-e...42b601d
build(deps-dev): Bump@typescript-eslint/parser
from 6.19.0 to 6.20.0627a535
Merge pull request #1227 from marocchino/dependabot/npm_and_yarn/ts-jest-29.1.285fbd23
Merge pull request #1239 from marocchino/dependabot/npm_and_yarn/types/node-2...9ecb719
Merge pull request #1240 from marocchino/dependabot/npm_and_yarn/octokit/grap...76f17ea
Merge pull request #1238 from MauriceArikoglu/patch-1b11ff05
build(deps): Bump@octokit/graphql-schema
from 14.47.1 to 14.52.0e141788
build(deps-dev): Bump@types/node
from 20.11.5 to 20.11.14You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)