Enable sending host tags with metrics for a configurable duration #22467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host tags are added to all metrics when `expected_tags_duration` is configured. This matches the behavior of the logs agent.
Go Package Import DifferencesBaseline: 38b9d04
|
gh123man
changed the title
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: cd3e955e-cb44-40a2-b5be-ad0759643705 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +1.76 | [-4.86, +8.37] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_to_blackhole | % cpu utilization | +1.76 | [-4.86, +8.37] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.44 | [+0.37, +0.50] |
| ➖ | process_agent_real_time_mode | memory utilization | +0.40 | [+0.35, +0.45] |
| ➖ | idle | memory utilization | +0.24 | [+0.21, +0.27] |
| ➖ | process_agent_standard_check | memory utilization | +0.09 | [+0.05, +0.13] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.03 | [+0.02, +0.05] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.00, +0.00] |
| ➖ | file_tree | memory utilization | -0.02 | [-0.11, +0.06] |
| ➖ | trace_agent_json | ingress throughput | -0.03 | [-0.06, -0.00] |
| ➖ | otel_to_otel_logs | ingress throughput | -0.11 | [-0.70, +0.47] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.49 | [-0.53, -0.45] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.53 | [-1.96, +0.89] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
remeh
reviewed
Feb 1, 2024
scottopell
reviewed
Feb 2, 2024
releasenotes/notes/add-host-tags-to-metrics-8705f7b52d28d5f7.yaml
Outdated
Show resolved
Hide resolved
hestonhoffman
approved these changes
Feb 5, 2024
10 tasks
NouemanKHAL
approved these changes
Feb 12, 2024
scottopell
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Hi @gh123man
I made some comments on how the functionality is integrated with the tagger. I proposed some change to make it more integrated with the current FWK and communication between Tagger and WorkloadMetaStore.
There was a problem hiding this comment.
Hi @gh123man
thanks for the PR update. It is implementation that I was looking for 👍
I added to few comments to be sure it is well integrated in workloadmetastore
move logic into pull function
| return nil | ||
| } | ||
|
|
||
| tags := hostMetadataUtils.Get(ctx, false, c.config).System |
There was a problem hiding this comment.
quick question hostmetadata package is not a component yet?
There was a problem hiding this comment.
Host metadata is - but this function still depends on a bunch of non-component bits. So I assume that's the reason it has not yet been converted.
I think this would be on @DataDog/agent-shared-components roadmap.
releasenotes/notes/add-host-tags-to-metrics-8705f7b52d28d5f7.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Cedric Lamoriniere <[email protected]>
clamoriniere
approved these changes
Feb 15, 2024
scottopell
approved these changes
Feb 15, 2024
| return nil | ||
| } | ||
|
|
||
| log.Debugf("Adding host tags to metrics for %v", duration) |
There was a problem hiding this comment.
there was a warning here telling users that they set the duration too low. Was that not useful?
There was a problem hiding this comment.
The 1 min constraint is no longer relevant with the new design. I suppose I could add back a warning about it being < 0
There was a problem hiding this comment.
Actually there was no warning about it being <= 0 before.
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 49m) Use |
dd-mergequeue
bot
deleted the
brian/AMLII-1449-add-host-tags-to-metrics
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add host tags to metrics when
expected_tags_durationis configured. This matches the behavior of the logs agent.What does this PR do?
Allows host tags to be added to all metrics for a configurable amount of time.
Summary of changes:
comp/metadata/host/hostimpl/utils/and into it's own package to break a dependency cycle on the tagger. (Unrelated code in the util package was pulling in the tagger)Motivation
Additional Notes
Ive benchmarked these changes with dogstatsd stress tests. There is approximately a 5% increase in agent CPU while the host tags are being attached. The CPU returns to baseline when the tags expire. NOTE: these results are likely heavily dependent on the number of host tags. Our benchmark env attaches many.
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
datadog.yamltags":foo:bartags on every metric logged in the payloads.Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.