[experiment] Remove remote configuration from serverless agent #22457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go Package Import DifferencesBaseline: f0e5f93
|
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: b1e7ba19-ee8f-416f-b267-3fc11120ea22 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | idle | memory utilization | +0.16 | [+0.14, +0.18] |
| ➖ | file_tree | memory utilization | -0.01 | [-0.08, +0.06] |
| ➖ | file_to_blackhole | % cpu utilization | -0.87 | [-7.40, +5.66] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.16 | [+0.10, +0.22] |
| ➖ | idle | memory utilization | +0.16 | [+0.14, +0.18] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.03 | [+0.01, +0.05] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.06, +0.06] |
| ➖ | trace_agent_json | ingress throughput | +0.00 | [-0.03, +0.03] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.03, +0.03] |
| ➖ | file_tree | memory utilization | -0.01 | [-0.08, +0.06] |
| ➖ | process_agent_standard_check | memory utilization | -0.23 | [-0.27, -0.18] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.37 | [-0.41, -0.33] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.56 | [-0.60, -0.53] |
| ➖ | otel_to_otel_logs | ingress throughput | -0.68 | [-1.39, +0.04] |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.80 | [-2.23, +0.62] |
| ➖ | file_to_blackhole | % cpu utilization | -0.87 | [-7.40, +5.66] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
GustavoCaso
changed the title
GustavoCaso
commented
Jan 31, 2024
go.mod
Outdated
| @@ -84,14 +84,15 @@ replace ( | |||
| github.com/DataDog/datadog-agent/pkg/util/testutil => ./pkg/util/testutil | |||
| github.com/DataDog/datadog-agent/pkg/util/winutil => ./pkg/util/winutil/ | |||
| github.com/DataDog/datadog-agent/pkg/version => ./pkg/version | |||
| gopkg.in/DataDog/dd-trace-go.v1 => /Users/gustavo.caso/go/src/github.com/DataDog/dd-trace-go | |||
There was a problem hiding this comment.
I needed this to test my local copy
There was a problem hiding this comment.
@GustavoCaso How does the output of go tool nm $serverless_binary | grep go-tuf look like?
Also, are the only required changes to support this moving the interfaces Propagator, TextMapReader and TextMapWriter to a separate package? If yes, then we have a solution for Serverless.
The only difference that I foresee in the v2 implementation is that these interfaces won't be under ddtrace package, but a propagation package inside of the tracer package. As far as the propagation package doesn't import anything from tracer itself, it won't include any extra dependencies.
GustavoCaso
changed the title
Serverless Benchmark Results
tl;dr
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
Benchmark stats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.