Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPM-3173] Add logs; increase timeout for retry loop #22291

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

hmahmood
Copy link
Contributor

@hmahmood hmahmood commented Jan 23, 2024

What does this PR do?

Add logs and possible fix for failures like: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/416413084

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@hmahmood hmahmood added changelog/no-changelog component/system-probe team/networks [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card qa/done QA done before merge and regressions are covered by tests labels Jan 23, 2024
@hmahmood hmahmood added this to the 7.52.0 milestone Jan 23, 2024
@hmahmood hmahmood requested a review from a team as a code owner January 23, 2024 20:17
@pr-commenter
Copy link

pr-commenter bot commented Jan 23, 2024

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 70261dfa-54cf-41a3-bbcc-e9bdf50a0a57
Baseline: 077f23d
Comparison: 0ac1ec5
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
idle memory utilization +0.10 [+0.08, +0.13]
file_tree memory utilization -0.00 [-0.07, +0.07]
file_to_blackhole % cpu utilization -0.68 [-7.21, +5.86]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +0.72 [+0.05, +1.39]
process_agent_standard_check_with_stats memory utilization +0.29 [+0.26, +0.33]
idle memory utilization +0.10 [+0.08, +0.13]
trace_agent_msgpack ingress throughput +0.02 [+0.00, +0.03]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.06, +0.06]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.03, +0.03]
file_tree memory utilization -0.00 [-0.07, +0.07]
trace_agent_json ingress throughput -0.05 [-0.08, -0.03]
uds_dogstatsd_to_api_cpu % cpu utilization -0.18 [-1.60, +1.25]
process_agent_real_time_mode memory utilization -0.48 [-0.50, -0.45]
process_agent_standard_check memory utilization -0.54 [-0.58, -0.50]
tcp_syslog_to_blackhole ingress throughput -0.67 [-0.73, -0.61]
file_to_blackhole % cpu utilization -0.68 [-7.21, +5.86]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@hmahmood
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 23, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 47m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 5b4beaa into main Jan 23, 2024
222 checks passed
@dd-mergequeue dd-mergequeue bot deleted the hasan.mahmood/fix-test-gw-lookup branch January 23, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card mergequeue-status: done qa/done QA done before merge and regressions are covered by tests team/networks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants