render LastError on agent gui even when not JSON #21875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix display of go check errors in agent GUI, to match the
agent status
commandMotivation
Go checks that reported errors only displayed
Error: UNKNOWN ERROR
in the agent GUI. This happened because Python checks report errors as a JSON string, but Go checks don't.https://datadoghq.atlassian.net/browse/WINA-521
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Create an error in a go check, for example, configure the
win32_event_log
check to monitor an event log that doesn't exist.Then ensure that
agent status
command line, agent GUI collector status page, and the dashboard infra page, show the check error.Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label, with required eitherqa/done
orqa/no-code-change
labels, are applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.