Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render LastError on agent gui even when not JSON #21875

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

clarkb7
Copy link
Contributor

@clarkb7 clarkb7 commented Jan 4, 2024

What does this PR do?

Fix display of go check errors in agent GUI, to match the agent status command

Motivation

Go checks that reported errors only displayed Error: UNKNOWN ERROR in the agent GUI. This happened because Python checks report errors as a JSON string, but Go checks don't.

https://datadoghq.atlassian.net/browse/WINA-521

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Create an error in a go check, for example, configure the win32_event_log check to monitor an event log that doesn't exist.

Then ensure that agent status command line, agent GUI collector status page, and the dashboard infra page, show the check error.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@clarkb7 clarkb7 added this to the 7.51.0 milestone Jan 4, 2024
@clarkb7 clarkb7 requested review from a team as code owners January 4, 2024 21:36
Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if this could get a test, but since there's hardly any here now, I won't block review on that.

@clarkb7
Copy link
Contributor Author

clarkb7 commented Jan 5, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 5, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is going to start soon! (estimated merge in less than 45m)

you can cancel this operation by commenting your pull request with /merge -c!

@dd-mergequeue dd-mergequeue bot merged commit dfec782 into main Jan 5, 2024
174 of 175 checks passed
@dd-mergequeue dd-mergequeue bot deleted the branden.clark/agent-gui-go-check-error branch January 5, 2024 03:55
GustavoCaso added a commit that referenced this pull request Jan 5, 2024
GustavoCaso added a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants