Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] bundled rules per origin #21621

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

safchain
Copy link
Contributor

What does this PR do?

Apply bundled rules only on specific platform/probe.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

We shouldn't see any error on ebpfless platform for "rename" rules.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 26782419-469d-4de0-be8a-3b30791e2843
Baseline: b5ea082
Comparison: 37394bf
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_tree memory utilization +0.07 [-0.03, +0.17]
idle memory utilization -0.09 [-0.12, -0.07]
file_to_blackhole % cpu utilization -0.32 [-6.94, +6.29]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
otel_to_otel_logs ingress throughput +0.58 [-0.17, +1.33]
process_agent_standard_check_with_stats memory utilization +0.18 [+0.14, +0.22]
file_tree memory utilization +0.07 [-0.03, +0.17]
trace_agent_json ingress throughput +0.04 [+0.01, +0.07]
trace_agent_msgpack ingress throughput +0.02 [+0.01, +0.04]
dogstatsd_string_interner_128MiB_100 ingress throughput +0.00 [-0.05, +0.05]
dogstatsd_string_interner_8MiB_10k ingress throughput +0.00 [-0.04, +0.04]
dogstatsd_string_interner_8MiB_1k ingress throughput +0.00 [-0.04, +0.04]
dogstatsd_string_interner_8MiB_50k ingress throughput +0.00 [-0.04, +0.04]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.04, +0.04]
dogstatsd_string_interner_8MiB_100 ingress throughput -0.00 [-0.04, +0.04]
dogstatsd_string_interner_64MiB_1k ingress throughput -0.00 [-0.04, +0.04]
dogstatsd_string_interner_64MiB_100 ingress throughput -0.00 [-0.04, +0.04]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.06, +0.06]
dogstatsd_string_interner_128MiB_1k ingress throughput -0.00 [-0.05, +0.05]
dogstatsd_string_interner_8MiB_100k ingress throughput -0.00 [-0.00, +0.00]
idle memory utilization -0.09 [-0.12, -0.07]
process_agent_standard_check memory utilization -0.14 [-0.19, -0.09]
process_agent_real_time_mode memory utilization -0.29 [-0.31, -0.26]
file_to_blackhole % cpu utilization -0.32 [-6.94, +6.29]
tcp_syslog_to_blackhole ingress throughput -1.65 [-1.71, -1.60]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@safchain safchain force-pushed the safchain/bundled-per-probe branch from 56fd7dd to 974682c Compare December 19, 2023 10:13
@safchain safchain force-pushed the safchain/bundled-per-probe branch from 974682c to 37394bf Compare December 20, 2023 10:04
@safchain
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 20, 2023

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

you can cancel this operation by commenting your pull request with /merge -c!

@dd-devflow
Copy link

dd-devflow bot commented Dec 20, 2023

🚂 MergeQueue

Added to the queue.

There are 3 builds ahead of this PR! (estimated merge in less than 2h)

you can cancel this operation by commenting your pull request with /merge -c!

@dd-mergequeue dd-mergequeue bot merged commit 3966088 into main Dec 20, 2023
183 checks passed
@dd-mergequeue dd-mergequeue bot deleted the safchain/bundled-per-probe branch December 20, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants