Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set trace log level for our flakyest tests #21595

Merged
merged 7 commits into from
Dec 20, 2023

Conversation

akarpz
Copy link
Contributor

@akarpz akarpz commented Dec 15, 2023

What does this PR do?

sets a few tests to trace level and adds some trace logs for conntrack offsetguessing specifically. this will be pretty noisy/spammy for a bit in CI, but the hope is we should be able to remove this shortly once we are able to debug the failures with additional info.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@akarpz akarpz requested a review from a team as a code owner December 15, 2023 20:28
@pr-commenter
Copy link

pr-commenter bot commented Dec 15, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: 4c863cf9-dcf0-4bf1-971a-533ec80d360b
Baseline: 2618fb9
Comparison: 5c7d4f4
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Declared stable experiments that are now erratic

An experiment is erratic (i.e., not stable) if its coefficient of variation is at least 0.10.

perf experiment goal Δ mean % Δ mean % CI confidence
otel_to_otel_logs ingress throughput -3.22 [-3.96, -2.48] 100.00%

Declared erratic experiments that are now stable

An experiment is stable (i.e., not erratic) if its coefficient of variation is less than 0.10.

perf experiment goal Δ mean % Δ mean % CI confidence
idle memory utilization +0.22 [+0.19, +0.25] 100.00%
file_tree memory utilization -0.47 [-0.58, -0.37] 100.00%

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI confidence
file_to_blackhole % cpu utilization +1.01 [-5.64, +7.66] 19.75%
tcp_syslog_to_blackhole ingress throughput +0.70 [+0.64, +0.76] 100.00%
idle memory utilization +0.22 [+0.19, +0.25] 100.00%
process_agent_standard_check_with_stats memory utilization +0.18 [+0.14, +0.22] 100.00%
process_agent_standard_check memory utilization +0.13 [+0.08, +0.18] 100.00%
trace_agent_json ingress throughput +0.02 [-0.01, +0.04] 79.06%
dogstatsd_string_interner_8MiB_100 ingress throughput +0.02 [-0.02, +0.06] 51.90%
dogstatsd_string_interner_64MiB_1k ingress throughput +0.00 [-0.03, +0.04] 15.44%
dogstatsd_string_interner_8MiB_50k ingress throughput +0.00 [-0.04, +0.04] 0.00%
dogstatsd_string_interner_8MiB_1k ingress throughput +0.00 [-0.04, +0.04] 0.00%
dogstatsd_string_interner_8MiB_10k ingress throughput +0.00 [-0.04, +0.04] 0.00%
dogstatsd_string_interner_64MiB_100 ingress throughput +0.00 [-0.04, +0.04] 0.00%
uds_dogstatsd_to_api ingress throughput -0.00 [-0.04, +0.04] 0.00%
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.07, +0.07] 0.00%
dogstatsd_string_interner_128MiB_100 ingress throughput -0.00 [-0.05, +0.05] 0.00%
dogstatsd_string_interner_128MiB_1k ingress throughput -0.00 [-0.06, +0.06] 0.00%
trace_agent_msgpack ingress throughput -0.02 [-0.04, -0.01] 98.48%
dogstatsd_string_interner_8MiB_100k ingress throughput -0.03 [-0.05, -0.02] 99.97%
process_agent_real_time_mode memory utilization -0.34 [-0.37, -0.31] 100.00%
file_tree memory utilization -0.47 [-0.58, -0.37] 100.00%
otel_to_otel_logs ingress throughput -3.22 [-3.96, -2.48] 100.00%

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@akarpz akarpz added changelog/no-changelog team/networks [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Dec 19, 2023
@akarpz akarpz added this to the 7.51.0 milestone Dec 19, 2023
@akarpz akarpz changed the title set debug log level for our flakyest tests set trace log level for our flakyest tests Dec 19, 2023
@akarpz akarpz added the qa/done QA done before merge and regressions are covered by tests label Dec 19, 2023
@akarpz
Copy link
Contributor Author

akarpz commented Dec 19, 2023

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 19, 2023

🚂 MergeQueue

Pull request added to the queue.

There are 6 builds ahead! (estimated merge in less than 4h)

you can cancel this operation by commenting your pull request with /merge -c!

@dd-mergequeue dd-mergequeue bot merged commit 890419a into main Dec 20, 2023
215 checks passed
@dd-mergequeue dd-mergequeue bot deleted the akarpowich/debug_logs_flaky_tests branch December 20, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card mergequeue-status: done qa/done QA done before merge and regressions are covered by tests team/networks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants