Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge software definitions for integration installation for py2 and py3 #21194

Closed
wants to merge 5 commits into from

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Nov 30, 2023

What does this PR do?

Reattempt for #21041. This adds back the missing py2-specific exclusions that caused errors on some builds.

Motivation

#21041 actually failed to build Agent 6 on ARM, but was only caught after merge, and thus had to be reverted.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@alopezz alopezz requested review from a team as code owners November 30, 2023 09:09
@alopezz alopezz added changelog/no-changelog team/integrations [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Nov 30, 2023
@alopezz alopezz added this to the Triage milestone Nov 30, 2023
@pr-commenter
Copy link

pr-commenter bot commented Nov 30, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: fbd8e348-227f-4558-a5f5-ce722304cf32
Baseline: 3584679
Comparison: 6476c1a
Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization -0.06 [-6.71, +6.59]
file_tree memory utilization -0.09 [-0.19, +0.01]
idle memory utilization -0.17 [-0.19, -0.14]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +0.54 [+0.48, +0.60]
process_agent_standard_check_with_stats memory utilization +0.33 [+0.28, +0.37]
process_agent_real_time_mode memory utilization +0.16 [+0.13, +0.20]
process_agent_standard_check memory utilization +0.03 [-0.02, +0.08]
trace_agent_json ingress throughput +0.02 [-0.01, +0.05]
dogstatsd_string_interner_8MiB_100k ingress throughput +0.01 [-0.00, +0.02]
trace_agent_msgpack ingress throughput +0.01 [-0.02, +0.03]
dogstatsd_string_interner_64MiB_100 ingress throughput +0.00 [-0.04, +0.04]
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.06, +0.06]
dogstatsd_string_interner_128MiB_1k ingress throughput +0.00 [-0.05, +0.05]
dogstatsd_string_interner_64MiB_1k ingress throughput -0.00 [-0.04, +0.04]
dogstatsd_string_interner_8MiB_10k ingress throughput -0.00 [-0.05, +0.05]
dogstatsd_string_interner_128MiB_100 ingress throughput -0.00 [-0.05, +0.05]
dogstatsd_string_interner_8MiB_100 ingress throughput -0.00 [-0.04, +0.04]
dogstatsd_string_interner_8MiB_1k ingress throughput -0.00 [-0.04, +0.04]
uds_dogstatsd_to_api ingress throughput -0.00 [-0.04, +0.04]
dogstatsd_string_interner_8MiB_50k ingress throughput -0.02 [-0.07, +0.03]
file_to_blackhole % cpu utilization -0.06 [-6.71, +6.59]
file_tree memory utilization -0.09 [-0.19, +0.01]
idle memory utilization -0.17 [-0.19, -0.14]
otel_to_otel_logs ingress throughput -0.64 [-1.40, +0.13]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@alopezz alopezz force-pushed the alopez/omnibus/merge-py2-py3-definitions branch from a1b41d0 to 15844c5 Compare December 20, 2023 14:22
@alopezz
Copy link
Contributor Author

alopezz commented May 9, 2024

Not relevant anymore with all the changes that have happened since. We'll see if we end up revisiting this in the future.

@alopezz alopezz closed this May 9, 2024
@dd-devflow dd-devflow bot deleted the alopez/omnibus/merge-py2-py3-definitions branch July 4, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants