Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure service permissions gets updated on maintenance #21081

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Ensure service permissions gets updated on maintenance
  • Loading branch information
julien-lebot committed Nov 24, 2023
commit 2f0753af07e071049a4acf03c312ab2fa9845d6b
Original file line number Diff line number Diff line change
@@ -129,6 +129,14 @@ public Project ConfigureProject()
}
);

// Ensures that the "change" dialog also reinstall the product.
project.AddAction(new SetPropertyAction("REINSTALL", "ALL")
{
Condition = Conditions.Maintenance,
When = When.After,
Step = Step.FindRelatedProducts
});

// Conditionally include the PROCMON MSM while it is in active development to make it easier
// to build/ship without it.
if (!string.IsNullOrEmpty(Environment.GetEnvironmentVariable("WINDOWS_DDPROCMON_DRIVER")))
@@ -402,7 +410,7 @@ private static ServiceInstaller GenerateServiceInstaller(string name, string dis
StopOn = null,
Start = SvcStartType.auto,
DelayedAutoStart = true,
RemoveOn = SvcEvent.Uninstall_Wait,
RemoveOn = SvcEvent.InstallUninstall_Wait,
ServiceSid = ServiceSid.none,
FirstFailureActionType = FailureActionType.restart,
SecondFailureActionType = FailureActionType.restart,
@@ -437,7 +445,7 @@ private static ServiceInstaller GenerateDependentServiceInstaller(
// Tell MSI not to stop the services. We handle service stop manually in StopDDServices custom action.
StopOn = null,
Start = SvcStartType.demand,
RemoveOn = SvcEvent.Uninstall_Wait,
RemoveOn = SvcEvent.InstallUninstall_Wait,
ServiceSid = ServiceSid.none,
FirstFailureActionType = FailureActionType.restart,
SecondFailureActionType = FailureActionType.restart,