[CONTINT-3386] Cleanup K8S APIClient clients and informers, fix short watch on Helm and Orch. Explorer informers #21009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichards-87
approved these changes
Nov 21, 2023
releasenotes-dca/notes/fix-long-watch-short-cac006ec56e97970.yaml
Outdated
Show resolved
Hide resolved
Go Package Import DifferencesBaseline: 890419a
|
vboulineau
force-pushed
the
vboulineau/dca-helm-check-timeout
branch
2 times, most recently
from
c0513a3 to
d6df23a
Compare
paulcacheux
approved these changes
Dec 19, 2023
clamoriniere
approved these changes
Dec 19, 2023
mfpierre
approved these changes
Dec 19, 2023
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. There are 5 builds ahead! (estimated merge in less than 4h) you can cancel this operation by commenting your pull request with |
|
🚨 MergeQueue mergequeue build completed successfully, but the github api returned an error while merging the pr Details
Error: PUT https://api.github.com/repos/DataDog/datadog-agent/pulls/21009/merge: 405 Pull Request is not mergeable [] FullStacktrace: If you need support, contact us on slack #ci-interfaces with those details! |
…and Orch. Explorer informers
vboulineau
force-pushed
the
vboulineau/dca-helm-check-timeout
branch
from
d6df23a to
f8982ce
Compare
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: bda2ad08-f9f9-4625-8044-b5f957fa4e6c Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | file_tree | memory utilization | +0.45 | [+0.34, +0.55] |
| ➖ | idle | memory utilization | +0.20 | [+0.18, +0.22] |
| ➖ | file_to_blackhole | % cpu utilization | -0.03 | [-6.65, +6.59] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | otel_to_otel_logs | ingress throughput | +2.22 | [+1.47, +2.97] |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.54 | [+0.48, +0.61] |
| ➖ | file_tree | memory utilization | +0.45 | [+0.34, +0.55] |
| ➖ | idle | memory utilization | +0.20 | [+0.18, +0.22] |
| ➖ | process_agent_standard_check | memory utilization | +0.11 | [+0.06, +0.16] |
| ➖ | trace_agent_json | ingress throughput | +0.06 | [+0.03, +0.09] |
| ➖ | trace_agent_msgpack | ingress throughput | +0.05 | [+0.03, +0.07] |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.06, +0.06] |
| ➖ | dogstatsd_string_interner_64MiB_100 | ingress throughput | +0.00 | [-0.04, +0.04] |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.04, +0.04] |
| ➖ | dogstatsd_string_interner_8MiB_10k | ingress throughput | +0.00 | [-0.04, +0.04] |
| ➖ | dogstatsd_string_interner_8MiB_100 | ingress throughput | +0.00 | [-0.04, +0.04] |
| ➖ | dogstatsd_string_interner_8MiB_100k | ingress throughput | -0.00 | [-0.00, +0.00] |
| ➖ | dogstatsd_string_interner_128MiB_100 | ingress throughput | -0.00 | [-0.05, +0.05] |
| ➖ | dogstatsd_string_interner_64MiB_1k | ingress throughput | -0.00 | [-0.04, +0.04] |
| ➖ | dogstatsd_string_interner_8MiB_50k | ingress throughput | -0.00 | [-0.04, +0.04] |
| ➖ | dogstatsd_string_interner_8MiB_1k | ingress throughput | -0.00 | [-0.04, +0.04] |
| ➖ | dogstatsd_string_interner_128MiB_1k | ingress throughput | -0.00 | [-0.05, +0.05] |
| ➖ | file_to_blackhole | % cpu utilization | -0.03 | [-6.65, +6.59] |
| ➖ | process_agent_standard_check_with_stats | memory utilization | -0.14 | [-0.18, -0.10] |
| ➖ | process_agent_real_time_mode | memory utilization | -0.43 | [-0.47, -0.40] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tries to (partially) cleanup usage of shared K8S Clients and informers.
It introduces a dedicated set of clients for informers and clients for CRUD operations, the only difference being client timeout.
Motivation
Reduce number of
Listqueries done to APIServer in ~all cases. Most important on List with filtering (requiring a full re-list on APIServer side).Additional Notes
Possible Drawbacks / Trade-offs
A variable is added to define long watch timeout, set to
0currently (no timeout).Note that the APIServer may choose to timeout connections whenever it sees fit, it may trigger unwanted logs due to the custom
RoundTripper, needs to be verified.Describe how to test/QA your changes
We can verify the volume of queries made is reduced internally (see CONTINT-3386).
Non regression on KSM Core, Orch Explorer (especially CRD, unassigned pods and apiservices), External Metrics with and without CRD.
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.