-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor agent integrations software definitions: Simplify blocks and reduce their use #20933
Conversation
5a42901
to
77eb422
Compare
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: d1b37204-480a-400f-869d-51bb2bd08a26 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
cb52a6a
to
9c89855
Compare
6bbc25f
to
20f0e49
Compare
|
||
block "Create filtered requirements" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for naming them
6258761
to
91ddcef
Compare
`checks_to_install` is populated at build time and must therefore go inside a block
91ddcef
to
cbed789
Compare
What does this PR do?
Attempt at simplifying current build scripts.
Motivation
Working on related tasks, I found the use of
block
s confusing. Future work on AITS-269 might also benefit from some preparatory cleanup.Additional Notes
A big part of the diff is just indentation from removing blocks.
An important thing to understand is how these scripts run. The ruby scripts themselves are executed at "load time", but a big part of what they do is build a list of commands that are actually run at "build time". All Omnibus
Builder
methods are designed to build that list of commands.block
's are sort of a escape hatch here which allow you to write Ruby code that will be executed at "build time"; we can't fully get around using them in cases where we need to compute some stuff dynamically at "build time". But usingBuilder
methods inside theseblock
's makes the flow of execution very hard to understand, because it means adding "build time" commands at "build time" rather than at "load time".Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.