Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Autodiscovery deps in config package #20850

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

clamoriniere
Copy link
Contributor

@clamoriniere clamoriniere commented Nov 13, 2023

What does this PR do?

Remove unnecessarypkg/autodiscovery/common/types dependency in config package.

Motivation

Remove the need to create a go.mod in pkg/autodiscovery/common/types and remove the need of #20233

Additional Notes

Using viper.SetEnvKeyTransformer() was a nice idea, but it was creating an unwanted dependency to the pkg/autodiscovery/common/types. I think this PR is a trade off between using all viper capability and make the package config reusable.

Also I think a major refactoring of the config package should append at some point to split the configuration by fx.Component, so we don't have all the config in on package but instead a modular config based on can be used in an agent.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Test that the option prometheus_scrape.checks is still working, and that the prometheus scrape feature is working

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

Copy link

cit-pr-commenter bot commented Nov 13, 2023

Go Package Import Differences

Baseline: fceacae
Comparison: 03babc6

binaryosarchchange
process-agentlinuxamd64
+0, -1
-github.com/DataDog/datadog-agent/pkg/autodiscovery/common/types
process-agentlinuxarm64
+0, -1
-github.com/DataDog/datadog-agent/pkg/autodiscovery/common/types
process-agentwindowsamd64
+0, -1
-github.com/DataDog/datadog-agent/pkg/autodiscovery/common/types
process-agentdarwinamd64
+0, -1
-github.com/DataDog/datadog-agent/pkg/autodiscovery/common/types
process-agentdarwinarm64
+0, -1
-github.com/DataDog/datadog-agent/pkg/autodiscovery/common/types
heroku-process-agentlinuxamd64
+0, -1
-github.com/DataDog/datadog-agent/pkg/autodiscovery/common/types
serverlesslinuxamd64
+0, -1
-github.com/DataDog/datadog-agent/pkg/autodiscovery/common/types
serverlesslinuxarm64
+0, -1
-github.com/DataDog/datadog-agent/pkg/autodiscovery/common/types
system-probelinuxamd64
+0, -1
-github.com/DataDog/datadog-agent/pkg/autodiscovery/common/types
system-probelinuxarm64
+0, -1
-github.com/DataDog/datadog-agent/pkg/autodiscovery/common/types
system-probewindowsamd64
+0, -1
-github.com/DataDog/datadog-agent/pkg/autodiscovery/common/types

@pr-commenter
Copy link

pr-commenter bot commented Nov 14, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: ad1016be-ed78-40e3-a2c7-3cd38cd46846
Baseline: fceacae
Comparison: 03babc6
Total datadog-agent CPUs: 7

Explanation

A regression test is an integrated performance test for datadog-agent in a repeatable rig, with varying configuration for datadog-agent. What follows is a statistical summary of a brief datadog-agent run for each configuration across SHAs given above. The goal of these tests are to determine quickly if datadog-agent performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
tcp_syslog_to_blackhole ingress throughput +0.57 [+0.44, +0.70] 100.00%
file_tree egress throughput +0.37 [-1.49, +2.23] 25.70%
uds_dogstatsd_to_api ingress throughput +0.02 [-0.16, +0.20] 14.24%
dogstatsd_string_interner_8MiB_100k ingress throughput +0.02 [-0.03, +0.06] 43.40%
dogstatsd_string_interner_128MiB_1k ingress throughput +0.00 [-0.13, +0.14] 2.80%
dogstatsd_string_interner_8MiB_1k ingress throughput +0.00 [-0.10, +0.10] 1.14%
dogstatsd_string_interner_8MiB_100 ingress throughput +0.00 [-0.13, +0.13] 0.68%
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.15, +0.15] 0.53%
dogstatsd_string_interner_64MiB_100 ingress throughput +0.00 [-0.14, +0.14] 0.00%
trace_agent_msgpack ingress throughput -0.00 [-0.13, +0.13] 0.19%
dogstatsd_string_interner_128MiB_100 ingress throughput -0.00 [-0.14, +0.14] 0.21%
dogstatsd_string_interner_64MiB_1k ingress throughput -0.00 [-0.13, +0.13] 2.15%
dogstatsd_string_interner_8MiB_10k ingress throughput -0.00 [-0.02, +0.01] 20.75%
dogstatsd_string_interner_8MiB_50k ingress throughput -0.00 [-0.07, +0.06] 7.63%
trace_agent_json ingress throughput -0.03 [-0.16, +0.09] 34.00%
file_to_blackhole egress throughput -0.07 [-1.09, +0.94] 9.48%
idle egress throughput -0.12 [-2.58, +2.35] 6.16%
otel_to_otel_logs ingress throughput -0.12 [-1.70, +1.46] 9.88%

@clamoriniere clamoriniere marked this pull request as ready for review November 14, 2023 08:01
@clamoriniere clamoriniere requested review from a team as code owners November 14, 2023 08:01
@L3n41c L3n41c added this to the 7.51.0 milestone Nov 15, 2023
@clamoriniere clamoriniere force-pushed the clamoriniere/removeADdepsinConfigPKG branch from 0f34e53 to 03babc6 Compare November 22, 2023 08:50
@clamoriniere clamoriniere merged commit 3758b9a into main Nov 22, 2023
146 of 150 checks passed
@clamoriniere clamoriniere deleted the clamoriniere/removeADdepsinConfigPKG branch November 22, 2023 14:09
@L3n41c L3n41c mentioned this pull request Dec 8, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants