-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Autodiscovery deps in config package #20850
Conversation
Go Package Import DifferencesBaseline: fceacae
|
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: ad1016be-ed78-40e3-a2c7-3cd38cd46846 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
0f34e53
to
03babc6
Compare
What does this PR do?
Remove unnecessary
pkg/autodiscovery/common/types
dependency inconfig
package.Motivation
Remove the need to create a go.mod in
pkg/autodiscovery/common/types
and remove the need of #20233Additional Notes
Using
viper.SetEnvKeyTransformer()
was a nice idea, but it was creating an unwanted dependency to thepkg/autodiscovery/common/types
. I think this PR is a trade off between using all viper capability and make the packageconfig
reusable.Also I think a major refactoring of the
config
package should append at some point to split the configuration byfx.Component
, so we don't have all the config in on package but instead a modular config based on can be used in an agent.Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Test that the option
prometheus_scrape.checks
is still working, and that theprometheus scrape
feature is workingReviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.