Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sources flag to CLI get command #20785

Merged
merged 9 commits into from
Nov 22, 2023

Conversation

julesmcrt
Copy link
Contributor

@julesmcrt julesmcrt commented Nov 10, 2023

What does this PR do?

Add a flag to the CLI config get command in Cobra
Add a method to Viper wrapper to get all sources and their settings for a given key

Screenshot 2023-11-10 at 15 56 12

Motivation

Since this change was introduced #20591
This PR makes life easier for developers to debug their configuration changes

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

pkg/config/model/viper.go Outdated Show resolved Hide resolved
pkg/config/settings/http/server.go Outdated Show resolved Hide resolved
pkg/config/settings/http/server.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with two suggestions

pkg/config/settings/http/client.go Outdated Show resolved Hide resolved
pkg/config/settings/http/server.go Outdated Show resolved Hide resolved
@@ -42,6 +42,7 @@ type Reader interface {
GetProxies() *Proxy

GetSource(key string) Source
GetAllSources(key string) []valueWithSource
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public method should return public types.


fmt.Printf("sources and their value:\n")
for _, sourceVal := range sourcesVal {
sourceVal, ok := sourceVal.(map[string]interface{})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once valueWithSource is public we could use it here maybe ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I don't think so, the element can only be casted to map[string]interface{}
Perhaps because there is a HTTP call in between?

@julesmcrt julesmcrt requested a review from hush-hush November 14, 2023 17:05
@pr-commenter
Copy link

pr-commenter bot commented Nov 14, 2023

Bloop Bleep... Dogbot Here

Regression Detector Results

Run ID: a58c59ba-8c63-4b68-a97e-7ba19304135d
Baseline: 88321ac
Comparison: 5db617b
Total datadog-agent CPUs: 7

Explanation

A regression test is an integrated performance test for datadog-agent in a repeatable rig, with varying configuration for datadog-agent. What follows is a statistical summary of a brief datadog-agent run for each configuration across SHAs given above. The goal of these tests are to determine quickly if datadog-agent performance is changed and to what degree by a pull request.

Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval.

We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:

  1. The estimated |Δ mean %| ≥ 5.00%. This criterion intends to answer the question "Does the estimated change in mean optimization goal performance have a meaningful impact on your customers?". We assume that when |Δ mean %| < 5.00%, the impact on your customers is not meaningful. We also assume that a performance change in optimization goal is worth investigating whether it is an increase or decrease, so long as the magnitude of the change is sufficiently large.

  2. Zero is not in the 90.00% confidence interval "Δ mean % CI" about "Δ mean %". This statement is equivalent to saying that there is at least a 90.00% chance that the mean difference in optimization goal is not zero. This criterion intends to answer the question, "Is there a statistically significant difference in mean optimization goal performance?". It also means there is no more than a 10.00% chance this criterion reports a statistically significant difference when the true difference in mean optimization goal is zero -- a "false positive". We assume you are willing to accept a 10.00% chance of inaccurately detecting a change in performance when no true difference exists.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%.

Fine details of change detection per experiment.
experiment goal Δ mean % Δ mean % CI confidence
tcp_syslog_to_blackhole ingress throughput +0.95 [+0.82, +1.08] 100.00%
file_tree egress throughput +0.57 [-1.30, +2.44] 38.34%
process_agent_standard_check egress throughput +0.43 [-3.12, +3.98] 15.69%
idle egress throughput +0.42 [-2.12, +2.96] 21.35%
process_agent_real_time_mode egress throughput +0.27 [-2.24, +2.79] 14.09%
process_agent_standard_check_with_stats egress throughput +0.16 [-1.89, +2.21] 10.07%
tcp_dd_logs_filter_exclude ingress throughput +0.04 [-0.09, +0.18] 39.52%
dogstatsd_string_interner_8MiB_50k ingress throughput +0.02 [-0.02, +0.06] 50.61%
dogstatsd_string_interner_8MiB_100 ingress throughput +0.01 [-0.12, +0.14] 6.81%
dogstatsd_string_interner_64MiB_1k ingress throughput +0.00 [-0.13, +0.13] 1.10%
uds_dogstatsd_to_api ingress throughput +0.00 [-0.17, +0.17] 0.77%
dogstatsd_string_interner_128MiB_100 ingress throughput +0.00 [-0.14, +0.14] 0.03%
trace_agent_json ingress throughput -0.00 [-0.13, +0.13] 0.66%
dogstatsd_string_interner_64MiB_100 ingress throughput -0.00 [-0.14, +0.14] 0.70%
dogstatsd_string_interner_128MiB_1k ingress throughput -0.00 [-0.15, +0.14] 2.74%
dogstatsd_string_interner_8MiB_10k ingress throughput -0.00 [-0.03, +0.02] 23.15%
dogstatsd_string_interner_8MiB_1k ingress throughput -0.01 [-0.10, +0.09] 7.91%
dogstatsd_string_interner_8MiB_100k ingress throughput -0.01 [-0.07, +0.06] 16.64%
trace_agent_msgpack ingress throughput -0.01 [-0.14, +0.12] 12.79%
file_to_blackhole egress throughput -0.05 [-1.07, +0.97] 6.73%
otel_to_otel_logs ingress throughput -1.23 [-2.80, +0.33] 80.47%

@julesmcrt julesmcrt merged commit 7c02303 into main Nov 22, 2023
140 checks passed
@julesmcrt julesmcrt deleted the jules.macret/RC-1362/add-sources-flag-CLI-get-command branch November 22, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants