[ASCII-145] Extract render subpackge from status #20776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustmop
approved these changes
Nov 10, 2023
GustavoCaso
force-pushed
the
extract-render-subpackge-from-status
branch
from
c6c0cdc to
48453eb
Compare
Go Package Import DifferencesBaseline: a2ef092
|
GustavoCaso
force-pushed
the
extract-render-subpackge-from-status
branch
from
48453eb to
a5e97e8
Compare
This was referenced Nov 13, 2023
dianashevchenko
approved these changes
Nov 14, 2023
paulcacheux
approved these changes
Nov 14, 2023
sblumenthal
approved these changes
Nov 14, 2023
kkhor-datadog
approved these changes
Nov 15, 2023
hush-hush
reviewed
Nov 15, 2023
GustavoCaso
force-pushed
the
extract-render-subpackge-from-status
branch
from
58dec94 to
fe628cc
Compare
GustavoCaso
force-pushed
the
extract-collector-to-a-subpackage-of-status
branch
from
176f2de to
d8c61b3
Compare
GustavoCaso
force-pushed
the
extract-render-subpackge-from-status
branch
from
5f9922f to
65ca3d3
Compare
hush-hush
approved these changes
Nov 17, 2023
Base automatically changed from
extract-collector-to-a-subpackage-of-status
to
main
November 20, 2023 11:35
…ly use status/collector and status/render
GustavoCaso
force-pushed
the
extract-render-subpackge-from-status
branch
from
65ca3d3 to
7d61e71
Compare
GustavoCaso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR uses the work from this PR as the base.
The main takeaways from this PR are:
pkg/statuspackage.pkg/status/render(Probably the name could be change topkg/status/formatstatus/renderpackage. The result is less packages are importedcheck <check name>subcommand, so it no longer import the entirestatuspackage, but rather juststatus/collectorandstatus/render🎉Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
The output of the status commands works as expected.
Normal agent
agent statusagent check [checkName]agent launch-guiagent flare [caseID]Cluster agent
agent statusagent metamap [nodeName]agent flare [caseID]Process agent
/opt/datadog-agent/embedded/bin/process-agent statusSecurity Agent
agent statusReviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.