Fix agent not starting with api key missing on Windows #19887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow the main Datadog Agent to start even if the API key is missing.
|
@julien-lebot Does this PR supersede #19884? |
pgimalac
approved these changes
Oct 3, 2023
darccio
approved these changes
Oct 3, 2023
pgimalac
approved these changes
Oct 3, 2023
derekwbrown
approved these changes
Oct 3, 2023
Yes. I would just close 19884 |
|
Merging this on behalf of Julien. Supercedes #19884. |
derekwbrown
deleted the
julien.lebot/fix_agent_not_start_api_key_missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces an extra
Modulefor the Trace Agent config component that doesn't need the API key to start.Motivation
The main Datadog Agent should be able to start without an API key, but the Trace Agent doesn't. Since the Datadog Agent now requires the ability to read the Trace Agent config (I believe for internal telemetry), we should make sure it doesn't require an API key to start.
Additional Notes
Full CI pipeline here: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/pipelines/20843825/
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.