add fallback instance types for security agent functional tests #16303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcacheux
added
changelog/no-changelog
[deprecated] qa/skip-qa - use other qa/ labels
paulcacheux
changed the title
t2.xlarge for security agent functional tests
YoannGh
approved these changes
Mar 28, 2023
KSerrania
approved these changes
Mar 28, 2023
truthbk
pushed a commit
that referenced
this pull request
Apr 14, 2023
* fallback on `t2.xlarge` for security agent functional tests * even more fallbacks
truthbk
added a commit
that referenced
this pull request
Apr 15, 2023
* Update release.json and Go modules for 6/7.43.2-rc.1 * add fallback instance types for security agent functional tests (#16303) * fallback on `t2.xlarge` for security agent functional tests * even more fallbacks --------- Co-authored-by: Paul Cacheux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have been having some spot provisioning issues for the past few days, this PR fixes this issue by providing fallback instance types in case
t3.mediumis not available:t2.xlargewas chosen because this is the instance type use by system probe functional tests on amazon linuxt3.xlargewas chosen because this is the default value, used by most regular kitchen testsDocumentation pointing to this way of providing fallbacks: https://kitchen.ci/docs/drivers/aws/#instance_type
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.