Send device as a resource and not a tag #16264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a missing call to pull `device` out of tags into the resources section. This fixes a capitalization issue when device tag was not available in upper-case when sending metrics via v2 API (a special case compared to other tags).
Instead of pre-filling Device field, pass the device as a tag and make sure that the serialization code extracts the device information from the tag.
Co-authored-by: May Lee <[email protected]>
gh123man
approved these changes
Mar 27, 2023
|
@rpriyanshu9 @datsabk This PR changes how the device information is reported to the backend, but the tags you see on the metrics in the app should be the same. If you have any issues, please reach out to Datadog support. |
|
Thanks for the confirmation. I've opened up a datadog support ticket to report this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a missing call to pull
deviceout of tags into the resources section.This fixes a capitalization issue when device tag was not available in upper-case when sending metrics via v2 API (a special case compared to other tags).
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Create a device with an uppercase name and mount it:
Run the agent with the disk check enabled (usually enabled by default).
Check that
system.disk.freeand othersystem.diskmetrics have twodevicetags: one lowercased, one as is.Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.