-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factorize all the aggregator, forwarder and sender code used to send container_lifecycle
, container_image
and sbom
payloads.
#16084
Conversation
ac717af
to
a5b459d
Compare
used to send `container_lifecycle`, `container_image` and `sbom` payloads.
a5b459d
to
b86b42f
Compare
container_lifecycle
, container_image
and sbom
payloads.container_lifecycle
, container_image
and sbom
payloads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for team/agent-security related files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for cmd/cluster-agent-cloudfoundry/subcommands/run/command.go
owned by @DataDog/platform-integrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from @DataDog/opentelemetry perspective.
eeb719c
to
17b0450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What does this PR do?
Leverage the generic “EventPlatform” pipeline in the agent in order to factorize the aggregator, forwarder and sender code that was used to send the
container_lifecycle
,container_image
andsbom
payloads.Motivation
Get rid of duplicated pieces of code.
Additional Notes
The
contimage
andsbom
parts were introduced by #14962 and were inspired by thecontlcycle
one.All three are replaced by the generic EventPlatform pipeline in this PR.
The new parameters for the “EventPlatform” pipeline were added in
pkg/epforwarder/epforwarder.go
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Enable
container_image
andsbom
with this snippet ofvalues.yaml
file for the public Helm chart:and validate that container images are still visible in the app.
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.