[docker] override s6-overlay stage3 script avoiding s6 nuke #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlyF
force-pushed
the
charly/s6_rm_finish
branch
from
38fe913 to
828e001
Compare
xvello
force-pushed
the
charly/s6_rm_finish
branch
3 times, most recently
from
1a3ed74 to
daef6f1
Compare
xvello
changed the title
xvello
changed the title
override upstream stage3 with our own rebase gitlab-ci on master fix dockerfile misc cleanups reno override stage3 instead of finish
xvello
force-pushed
the
charly/s6_rm_finish
branch
from
1dde98c to
ce91863
Compare
hkaj
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upstream's (s6-overlay) stage3 script was executed on container stop. This script invokes
s6-nuke, that sends SIGKILL to every process in the PID namespace except PID1: https://github.com/just-containers/s6-overlay/blob/master/builder/overlay-rootfs/etc/s6/init/init-stage3#L45-L65This is not necessary when running in a container (as if there were leftover processes, it's docker's job to kill them and reparent zombies to PID1 for reaping), and can cause host system failures if running with
--pid=host.This PR replaces this stage3 with a custom script only doing logging + process reaping.