Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Remove reference to trace-agent.conf.example file #1294

Merged
merged 2 commits into from
Feb 19, 2018

Conversation

olivielpeau
Copy link
Member

We don't ship it anymore on Windows, and this ref makes the build
break.

We don't ship it anymore on Windows, and  this ref makes the build
break.
@olivielpeau olivielpeau added this to the 6.0.0-rc.2 milestone Feb 19, 2018
@olivielpeau olivielpeau requested a review from a team as a code owner February 19, 2018 16:16
@olivielpeau olivielpeau added kind/bug os/windows kind/packaging [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. changelog/no-changelog labels Feb 19, 2018
Copy link
Member

@arbll arbll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's just wait for the pipeline to be safe.

@olivielpeau
Copy link
Member Author

Windows pkg build passes. Merging

@olivielpeau olivielpeau merged commit 7a59060 into master Feb 19, 2018
@olivielpeau olivielpeau deleted the olivielpeau/fix-windows-trace-conf branch February 19, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. kind/bug kind/packaging os/windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants