Skip to content

Commit

Permalink
Adding is_trace_root tag for APM Stats (#23302)
Browse files Browse the repository at this point in the history
* proto change to add is_parent_root

* move field

* proto and isParentRoot usage in the bucketAggKey

* test fixes

* test fixes

* rename to isTraceRoot and refactor tests

* unit tests

* root_tag unit tests

* change isTraceRoot from bool to enum

* made root tags a separate test in concentrator_test.go

* release notes

* whitespace

* Update releasenotes/notes/apm-adding-is_trace_root-tag-for-APM-Stats-f3f4384105897d11.yaml

Co-authored-by: Rosa Trieu <[email protected]>

* changes

---------

Co-authored-by: Rosa Trieu <[email protected]>
  • Loading branch information
2 people authored and alexgallotta committed May 9, 2024
1 parent 295a14b commit fbffdf2
Show file tree
Hide file tree
Showing 12 changed files with 358 additions and 52 deletions.
7 changes: 7 additions & 0 deletions pkg/proto/datadog/trace/stats.proto
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ message ClientStatsBucket {
int64 agentTimeShift = 4;
}

enum TraceRootFlag {
NOT_SET = 0;
TRUE = 1;
FALSE = 2;
}

// ClientGroupedStats aggregate stats on spans grouped by service, name, resource, status_code, type
message ClientGroupedStats {
string service = 1;
Expand All @@ -82,4 +88,5 @@ message ClientGroupedStats {
// peer_tags are supplementary tags that further describe a peer entity
// E.g., `grpc.target` to describe the name of a gRPC peer, or `db.hostname` to describe the name of peer DB
repeated string peer_tags = 16;
TraceRootFlag is_trace_root = 17; // this field's value is equal to span's ParentID == 0.
}
107 changes: 88 additions & 19 deletions pkg/proto/pbgo/trace/stats.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

96 changes: 91 additions & 5 deletions pkg/proto/pbgo/trace/stats_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 29 additions & 0 deletions pkg/proto/pbgo/trace/stats_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit fbffdf2

Please sign in to comment.