fix(notify): Handle case with undefined variable

DataDog · Dec 19, 2024 · f193de1 · f193de1
1 parent 9056fb7
commit f193de1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tasks/libs/notify/utils.py b/tasks/libs/notify/utils.py
@@ -65,7 +65,7 @@ def notification_type():
     """
     Return the type of notification to send (related to the type of pipeline, amongst 'deploy', 'trigger' and 'merge')
     """
-    if os.environ['DEPLOY_AGENT'] == 'true':
+    if os.environ.get('DEPLOY_AGENT', '') == 'true':
         return 'deploy'
     elif os.environ['CI_PIPELINE_SOURCE'] != 'push':
         return 'trigger'

diff --git a/tasks/unit_tests/notify_tests.py b/tasks/unit_tests/notify_tests.py
@@ -31,7 +31,7 @@ def get_github_slack_map():
 
 
 class TestSendMessage(unittest.TestCase):
-    @patch.dict('os.environ', {'DEPLOY_AGENT': 'false', 'CI_PIPELINE_SOURCE': 'push', 'CI_PIPELINE_ID': '42'})
+    @patch.dict('os.environ', {'CI_PIPELINE_SOURCE': 'push', 'CI_PIPELINE_ID': '42'})
     @patch('tasks.libs.pipeline.notifications.get_pr_from_commit', new=MagicMock(return_value=""))
     @patch('builtins.print')
     @patch('tasks.libs.ciproviders.gitlab_api.get_gitlab_api')