Skip to content

Commit

Permalink
[CI] Remove addition of ldflags to fix an old issue using the -race f…
Browse files Browse the repository at this point in the history
…lag on Windows (#21288)
  • Loading branch information
amenasria authored Dec 5, 2023
1 parent c19995c commit 9836156
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion tasks/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,6 @@ def test(
python_home_3=python_home_3,
major_version=major_version,
python_runtimes=python_runtimes,
race=race,
)

# Use stdout if no profile is set
Expand Down
7 changes: 0 additions & 7 deletions tasks/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ def get_build_flags(
major_version='7',
python_runtimes='3',
headless_mode=False,
race=False,
):
"""
Build the common value for both ldflags and gcflags, and return an env accordingly.
Expand Down Expand Up @@ -217,12 +216,6 @@ def get_build_flags(
if extldflags:
ldflags += f"'-extldflags={extldflags}' "

# Needed to fix an issue when using -race + gcc 10.x on Windows
# https://github.com/bazelbuild/rules_go/issues/2614
if race:
if sys.platform == 'win32':
ldflags += " -linkmode=external"

return ldflags, gcflags, env


Expand Down

0 comments on commit 9836156

Please sign in to comment.