Fix fakeintake logs client which was returning an empty tags list (#2…

…1073)
DataDog · Nov 24, 2023 · 8269452 · 8269452
1 parent 0937077
commit 8269452
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 9 deletions.
diff --git a/test/fakeintake/aggregator/fixtures/log_bytes b/test/fakeintake/aggregator/fixtures/log_bytes
diff --git a/test/fakeintake/aggregator/logAggregator.go b/test/fakeintake/aggregator/logAggregator.go
@@ -8,20 +8,36 @@ package aggregator
 import (
 	"bytes"
 	"encoding/json"
+	"strings"
 	"time"
 
 	"github.com/DataDog/datadog-agent/test/fakeintake/api"
 )
 
+type tags []string
+
 type Log struct {
 	collectedTime time.Time
-	Message       string   `json:"message"`
-	Status        string   `json:"status"`
-	Timestamp     int      `json:"timestamp"`
-	HostName      string   `json:"hostname"`
-	Service       string   `json:"service"`
-	Source        string   `json:"source"`
-	Tags          []string `json:"tags"`
+	Message       string `json:"message"`
+	Status        string `json:"status"`
+	Timestamp     int    `json:"timestamp"`
+	HostName      string `json:"hostname"`
+	Service       string `json:"service"`
+	Source        string `json:"ddsource"`
+	Tags          tags   `json:"ddtags"`
+}
+
+func (t *tags) UnmarshalJSON(b []byte) error {
+	var s string
+	if err := json.Unmarshal(b, &s); err != nil {
+		return err
+	}
+	*t = tags(strings.Split(s, ","))
+	return nil
+}
+
+func (t tags) MarshalJSON() ([]byte, error) {
+	return json.Marshal(strings.Join(t, ","))
 }
 
 func (l *Log) name() string {

diff --git a/test/fakeintake/server/fixture_test/log_bytes b/test/fakeintake/server/fixture_test/log_bytes
diff --git a/test/fakeintake/server/server_test.go b/test/fakeintake/server/server_test.go
@@ -143,9 +143,9 @@ func TestServer(t *testing.T) {
 						"hostname":  "totoro",
 						"message":   "Hello, can you hear me",
 						"service":   "callme",
-						"source":    "Adele",
+						"ddsource":  "Adele",
 						"status":    "Info",
-						"tags":      []interface{}{"singer:adele"},
+						"ddtags":    "singer:adele",
 						"timestamp": float64(0)}},
 					Encoding: "gzip",
 				},