Fix error log during cluster check runner init (#20924)

* pkg/autodiscovery/providers/clusterchecks.go * add release note * address comment * Update releasenotes/notes/fix_repeating_error_log_in_clc-7950ee986a560770.yaml Co-authored-by: Austin Lai <[email protected]> --------- Co-authored-by: Austin Lai <[email protected]>
DataDog · Nov 22, 2023 · 7a05bb2 · 7a05bb2
1 parent dbcc248
commit 7a05bb2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/pkg/autodiscovery/providers/clusterchecks.go b/pkg/autodiscovery/providers/clusterchecks.go
@@ -191,11 +191,11 @@ func (c *ClusterChecksConfigProvider) heartbeatSender(ctx context.Context) {
 				postCtx, cancel := context.WithTimeout(ctx, postStatusTimeout)
 				defer cancel()
 				if err := c.postHeartbeat(postCtx); err == nil {
-					extraHeartbeatTime = currentTime
 					log.Infof("Sent extra heartbeat at: %v", currentTime)
 				} else {
 					log.Warnf("Unable to send extra heartbeat to Cluster Agent, err: %v", err)
 				}
+				extraHeartbeatTime = currentTime
 			}
 
 		case <-ctx.Done():
@@ -206,7 +206,7 @@ func (c *ClusterChecksConfigProvider) heartbeatSender(ctx context.Context) {
 
 func (c *ClusterChecksConfigProvider) postHeartbeat(ctx context.Context) error {
 	if c.dcaClient == nil {
-		return errors.New("DCA Client not initialized by main provider, cannot post heartbeat")
+		return errors.New("DCA Client not initialized by main provider yet, cannot post heartbeat, wait for init completion")
 	}
 
 	status := types.NodeStatus{

diff --git a/releasenotes/notes/fix_repeating_error_log_in_clc-7950ee986a560770.yaml b/releasenotes/notes/fix_repeating_error_log_in_clc-7950ee986a560770.yaml
@@ -0,0 +1,4 @@
+---
+fixes:
+  - |
+    Fix a spewing error message ("DCA Client not initialized by main provider, cannot post heartbeat") in the cluster check runner log during CLC initialization.